From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 594A2C7619A for ; Wed, 5 Apr 2023 15:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233443AbjDEPaW (ORCPT ); Wed, 5 Apr 2023 11:30:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238367AbjDEPaP (ORCPT ); Wed, 5 Apr 2023 11:30:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF7C711C for ; Wed, 5 Apr 2023 08:30:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B829623C3 for ; Wed, 5 Apr 2023 15:30:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6901FC4339B; Wed, 5 Apr 2023 15:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680708602; bh=LeMKsBCVGhK0MI4/E8VrsHhqZf3Xhzs6ITLdf0ftaFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UNuxiewJOHwA189SknqRmyy9Bb7uDtGn+4VBc4AJZviZOaFLN2rFpqhgGeTsiKCCq 6DRxsRtmN/iVWdSJCBaFo7FPvbOUGxf8kaHwoACcMyy7yinjQ/taTQ8687qPGCAQeu K9AKLOziTgt180WwvmxNZ3k6S5bT6ixc7q9HVbXMISedPvtvYHfculAD0NmTTk64of OWKzmFAOZ7Cn11BnPj/rO6rtvQM8XzMMpoM3fu3VwUUUucMraSOpL+/TSDNeh9ccA5 WD9+/UpE006EMK5HU3941+UVhPmCzYw0l5g6w6PgKF4BJ93H8t+jT5TwrxvFqm+5w8 Nh9bDwmf8qiMQ== Date: Wed, 5 Apr 2023 09:29:59 -0600 From: Keith Busch To: Jens Axboe Cc: io-uring , Kanchan Joshi Subject: Re: [PATCH] io_uring/uring_cmd: assign ioucmd->cmd at async prep time Message-ID: References: <863daab3-c397-85fc-4db5-b61e02ced047@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <863daab3-c397-85fc-4db5-b61e02ced047@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Wed, Apr 05, 2023 at 08:23:15AM -0600, Jens Axboe wrote: > Rather than check this in the fast path issue, it makes more sense to > just assign the copy of the data when we're setting it up anyway. This > makes the code a bit cleaner, and removes the need for this check in > the issue path. Looks good. Reviewed-by: Keith Busch