From: Breno Leitao <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected]
Subject: Re: [PATCH v2 0/3] io_uring: Pass the whole sqe to commands
Date: Sun, 30 Apr 2023 07:39:10 -0700 [thread overview]
Message-ID: <ZE59jseq/[email protected]> (raw)
In-Reply-To: <[email protected]>
Hello Jens,
On Fri, Apr 28, 2023 at 11:28:14AM -0600, Jens Axboe wrote:
> On 4/21/23 5:44?AM, Breno Leitao wrote:
> > These three patches prepare for the sock support in the io_uring cmd, as
> > described in the following RFC:
> >
> > https://lore.kernel.org/lkml/[email protected]/
> >
> > Since the support linked above depends on other refactors, such as the sock
> > ioctl() sock refactor[1], I would like to start integrating patches that have
> > consensus and can bring value right now. This will also reduce the patchset
> > size later.
> >
> > Regarding to these three patches, they are simple changes that turn
> > io_uring cmd subsystem more flexible (by passing the whole SQE to the
> > command), and cleaning up an unnecessary compile check.
> >
> > These patches were tested by creating a file system and mounting an NVME disk
> > using ubdsrv/ublkb0.
>
> Looks mostly good to me, do agree with Christoph's comments on the two
> patches. Can you spin a v3? Would be annoying to miss 6.4 with this, as
> other things will be built on top of it.
Sure. I've just sent V3 with all the fixes discussed in this email
thread.
Here is the link: https://lkml.org/lkml/2023/4/30/91
prev parent reply other threads:[~2023-04-30 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230421114703epcas5p37cd0ddb29674d8f3d5fe2f1fa494d1f0@epcas5p3.samsung.com>
2023-04-21 11:44 ` [PATCH v2 0/3] io_uring: Pass the whole sqe to commands Breno Leitao
2023-04-21 11:44 ` [PATCH v2 1/3] io_uring: Create a helper to return the SQE size Breno Leitao
2023-04-24 7:19 ` Christoph Hellwig
2023-04-21 11:44 ` [PATCH v2 2/3] io_uring: Pass whole sqe to commands Breno Leitao
2023-04-24 7:23 ` Christoph Hellwig
2023-04-21 11:44 ` [PATCH v2 3/3] io_uring: Remove unnecessary BUILD_BUG_ON Breno Leitao
2023-04-24 7:23 ` Christoph Hellwig
2023-04-28 17:27 ` Jens Axboe
2023-04-21 12:16 ` [PATCH v2 0/3] io_uring: Pass the whole sqe to commands Kanchan Joshi
2023-04-28 17:28 ` Jens Axboe
2023-04-30 14:39 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZE59jseq/[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox