From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145A0C7618E for ; Mon, 24 Apr 2023 07:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbjDXHbz (ORCPT ); Mon, 24 Apr 2023 03:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbjDXHbx (ORCPT ); Mon, 24 Apr 2023 03:31:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE53BE6C for ; Mon, 24 Apr 2023 00:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682321465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ipmx76x/vn80kAt9F/7tYhwI8EBbjLDtt/zG6cn0dgw=; b=BQfaU1/Ohz4ElTSP5ltFppNdkuoQfKfRQ8EK6ZUsCRO5wvoYuBzBx4cCjMxdW+NyCU9H9S mFLz/706QTXcx+6Y/NDhT+SG8qR5ouh9mekG3r9shncOckSMFzl5+pG2dGKqahD4qIxIVr be7IYE4nWZWQrb45w/64yv8fPf2KNA0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-633-GrCz4u9CNWiHltAkEHryZg-1; Mon, 24 Apr 2023 03:30:19 -0400 X-MC-Unique: GrCz4u9CNWiHltAkEHryZg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D01763C0252D; Mon, 24 Apr 2023 07:30:18 +0000 (UTC) Received: from ovpn-8-16.pek2.redhat.com (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 391D22027045; Mon, 24 Apr 2023 07:30:15 +0000 (UTC) Date: Mon, 24 Apr 2023 15:30:10 +0800 From: Ming Lei To: Jens Axboe Cc: io-uring@vger.kernel.org, ming.lei@redhat.com Subject: Re: [PATCH 4/4] io_uring: mark opcodes that always need io-wq punt Message-ID: References: <20230420183135.119618-1-axboe@kernel.dk> <20230420183135.119618-5-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230420183135.119618-5-axboe@kernel.dk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Apr 20, 2023 at 12:31:35PM -0600, Jens Axboe wrote: > Add an opdef bit for them, and set it for the opcodes where we always > need io-wq punt. With that done, exclude them from the file_can_poll() > check in terms of whether or not we need to punt them if any of the > NO_OFFLOAD flags are set. > > Signed-off-by: Jens Axboe > --- > io_uring/io_uring.c | 2 +- > io_uring/opdef.c | 22 ++++++++++++++++++++-- > io_uring/opdef.h | 2 ++ > 3 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index fee3e461e149..420cfd35ebc6 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -1948,7 +1948,7 @@ static int io_issue_sqe(struct io_kiocb *req, unsigned int issue_flags) > return -EBADF; > > if (issue_flags & IO_URING_F_NO_OFFLOAD && > - (!req->file || !file_can_poll(req->file))) > + (!req->file || !file_can_poll(req->file) || def->always_iowq)) > issue_flags &= ~IO_URING_F_NONBLOCK; I guess the check should be !def->always_iowq? Thanks, Ming