public inbox for [email protected]
 help / color / mirror / Atom feed
From: Breno Leitao <[email protected]>
To: Jakub Kicinski <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>,
	Jonathan Corbet <[email protected]>, Jens Axboe <[email protected]>,
	Pavel Begunkov <[email protected]>,
	"David S. Miller" <[email protected]>,
	Eric Dumazet <[email protected]>,
	Paolo Abeni <[email protected]>,
	[email protected], Arnd Bergmann <[email protected]>,
	Steve French <[email protected]>,
	Lu Baolu <[email protected]>,
	Jiri Slaby <[email protected]>,
	Stephen Hemminger <[email protected]>,
	Jason Gunthorpe <[email protected]>, Simon Ser <[email protected]>,
	"open list:DOCUMENTATION" <[email protected]>,
	open list <[email protected]>,
	"open list:IO_URING" <[email protected]>,
	"open list:NETWORKING [GENERAL]" <[email protected]>
Subject: Re: [PATCH] io_uring: Add io_uring command support for sockets
Date: Thu, 22 Jun 2023 12:01:44 -0700	[thread overview]
Message-ID: <ZJSamAduIRJ3b/[email protected]> (raw)
In-Reply-To: <[email protected]>

On Thu, Jun 22, 2023 at 10:39:48AM -0700, Jakub Kicinski wrote:
> On Thu, 22 Jun 2023 19:03:04 +0200 Greg Kroah-Hartman wrote:
> > > Correct. For now we are just using 0xa0 and 0xa1, and eventually we
> > > might need more ioctls numbers.
> > > 
> > > I got these numbers finding a unused block and having some room for
> > > expansion, as suggested by Documentation/userspace-api/ioctl/ioctl-number.rst,
> > > that says:
> > > 
> > > 	If you are writing a driver for a new device and need a letter, pick an
> > > 	unused block with enough room for expansion: 32 to 256 ioctl commands.  
> > 
> > So is this the first io_uring ioctl?  If so, why is this an ioctl and
> > not just a "normal" io_uring call?
> 
> +1, the mixing with classic ioctl seems confusing and I'm not sure 
> if it buys us anything.

Sure, let me remove the dependency on ioctl()s then.

  reply	other threads:[~2023-06-22 19:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 23:21 [PATCH] io_uring: Add io_uring command support for sockets Breno Leitao
2023-06-22  5:20 ` Greg Kroah-Hartman
2023-06-22 15:02   ` Breno Leitao
2023-06-22 16:10     ` Greg Kroah-Hartman
2023-06-22 16:38       ` Breno Leitao
2023-06-22 17:03         ` Greg Kroah-Hartman
2023-06-22 17:39           ` Jakub Kicinski
2023-06-22 19:01             ` Breno Leitao [this message]
2023-06-22 18:57           ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJSamAduIRJ3b/[email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox