From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876E8EB64DC for ; Thu, 22 Jun 2023 19:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbjFVTBu (ORCPT ); Thu, 22 Jun 2023 15:01:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjFVTBt (ORCPT ); Thu, 22 Jun 2023 15:01:49 -0400 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A4659B; Thu, 22 Jun 2023 12:01:48 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-31121494630so8626255f8f.3; Thu, 22 Jun 2023 12:01:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687460506; x=1690052506; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JQKzGLLngarWVhVTw2URKzbQiX5Xh0ThcGjikbK/29A=; b=UDaogkxedFUKrLBbokO3Ju1XWzQsshU4NzizhE111YxjVL/KNgAdifnWs3aZVyEqnh vZLqxNQG2p5Z41RNyZ2k1HYP7KJToFUID1byUceENvRpFn2nmR/Fk/3WzleWGvlOzZBg cbtsILSaBxvPwgt6bsmd3HEx6TR2HX3bnAuRa0OHGTEDRRUKAYhbmcvyN+XtUXdS/smy TqIuucLOcep/obdp00dn2uafwYJ/S4an7+fCBuCNKM4VQh2n7V5rQ5kAexgk9ST+XZnL BsB9yEtdUnp3AvAw+5NPltZEX4Znv66aHgXRugSSkasJa4s8vfAHsOaoVqBv/jNSCYWT wHaw== X-Gm-Message-State: AC+VfDzUGonVeZqp2rk4tW0X5cz5cCvSnqP0udUDlT/eVoGBUMoR85aJ NuctXn7FZLyWZHinSTcAZt0= X-Google-Smtp-Source: ACHHUZ4Fm507H6gAfhlPKOCV3A52LQqvUW+RMQ+AjS6G760+nRpx0UGIk5+/UcW36fRpV4dsuqghUA== X-Received: by 2002:a5d:67cd:0:b0:2ef:b052:1296 with SMTP id n13-20020a5d67cd000000b002efb0521296mr17148852wrw.22.1687460506529; Thu, 22 Jun 2023 12:01:46 -0700 (PDT) Received: from gmail.com (fwdproxy-cln-004.fbsv.net. [2a03:2880:31ff:4::face:b00c]) by smtp.gmail.com with ESMTPSA id j11-20020a5d604b000000b003078681a1e8sm7680789wrt.54.2023.06.22.12.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 12:01:46 -0700 (PDT) Date: Thu, 22 Jun 2023 12:01:44 -0700 From: Breno Leitao To: Jakub Kicinski Cc: Greg Kroah-Hartman , Jonathan Corbet , Jens Axboe , Pavel Begunkov , "David S. Miller" , Eric Dumazet , Paolo Abeni , leit@meta.com, Arnd Bergmann , Steve French , Lu Baolu , Jiri Slaby , Stephen Hemminger , Jason Gunthorpe , Simon Ser , "open list:DOCUMENTATION" , open list , "open list:IO_URING" , "open list:NETWORKING [GENERAL]" Subject: Re: [PATCH] io_uring: Add io_uring command support for sockets Message-ID: References: <20230621232129.3776944-1-leitao@debian.org> <2023062231-tasting-stranger-8882@gregkh> <2023062208-animosity-squabble-c1ba@gregkh> <2023062228-cloak-wish-ec12@gregkh> <20230622103948.33cbb0dd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622103948.33cbb0dd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Jun 22, 2023 at 10:39:48AM -0700, Jakub Kicinski wrote: > On Thu, 22 Jun 2023 19:03:04 +0200 Greg Kroah-Hartman wrote: > > > Correct. For now we are just using 0xa0 and 0xa1, and eventually we > > > might need more ioctls numbers. > > > > > > I got these numbers finding a unused block and having some room for > > > expansion, as suggested by Documentation/userspace-api/ioctl/ioctl-number.rst, > > > that says: > > > > > > If you are writing a driver for a new device and need a letter, pick an > > > unused block with enough room for expansion: 32 to 256 ioctl commands. > > > > So is this the first io_uring ioctl? If so, why is this an ioctl and > > not just a "normal" io_uring call? > > +1, the mixing with classic ioctl seems confusing and I'm not sure > if it buys us anything. Sure, let me remove the dependency on ioctl()s then.