From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 692B6C001DC for ; Wed, 26 Jul 2023 22:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbjGZWBK (ORCPT ); Wed, 26 Jul 2023 18:01:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbjGZWBI (ORCPT ); Wed, 26 Jul 2023 18:01:08 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 265712109 for ; Wed, 26 Jul 2023 15:01:07 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1bba48b0bd2so1858355ad.3 for ; Wed, 26 Jul 2023 15:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1690408866; x=1691013666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+WAq+j8rpwE8jCLQS/mfI/ZnBgNEzR7nuJ5WnOlJ1To=; b=LcIfUPbXibFKOcwZyNPdEPd2BAOIawA7Piuq8jlnCvvo8HOZA9xXNry3iC2H0Fd6ZB cSd3Eret8x0pxP52DOr+piDJiw05JdJL0c/uaMFpJioI7du0ito8SSc7xEpzs7x7KRdW CJSmkQwnHIR16kBQyyRL9RWImlNFGYMbRNOm0blQxc3o0pmRskX23x0r+iqpBou0vGR7 KvVk+gP7aX2dowabeNtQn0LL5VeIivtzWlPCc71dRhDUgyICPsVbhWcNmbc43RLeHF/h oq7tnG7t6RtS8GpYvpBBoSE+fJ8whUZbziQYul5jIollF0H96gUJAqr+JpXTWieWcMwK Q4qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690408866; x=1691013666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+WAq+j8rpwE8jCLQS/mfI/ZnBgNEzR7nuJ5WnOlJ1To=; b=DnIorjiN3howRzJyC4F97eU2cMuRuvkExoOho0ybhP5WN43P4qTN+3sDsrCplktN34 Qpf7GY1VEIoD8v8cTOAIre3nhKaFeycattxFqeavkODfgGJszoUfCA5hRUSMkesNIq9G al5QdGahXmpH8yjZUSz7ofvF/MZKEKTidtp4hkx1Tdzu65hZ6JwtO6r6i1uiSJ4tMpFr 7qi750qy9PhUE4whf4HiB7fTi9LQWG4ZeJHA0B0b/2JTfUJO1SAfi3Nqs2Jpoj+hbdhW l5RUCfjrZ6S6SOZu3Ut4l05oAJBbH4D3h+h0C8jXtmLNWUfIwUsyBjhiHuWGfn9L6fzd O0Dg== X-Gm-Message-State: ABy/qLbJETWHSZRu7NDiHrWe/rkJeBu3Qbzw8SsIW/+lSHJnIq23z8c7 GsCaUcOQt6sbSrCEuqzsvNjn5w== X-Google-Smtp-Source: APBJJlGh8nBKWSdToAnmGsCSTUJ3ncEp5T8HpMsW+UsFO7Ykt5aeLDuiVsMLRb3wQpYHPh8ZOTRIQw== X-Received: by 2002:a17:902:ea06:b0:1b8:a67f:1c0f with SMTP id s6-20020a170902ea0600b001b8a67f1c0fmr3344752plg.39.1690408865163; Wed, 26 Jul 2023 15:01:05 -0700 (PDT) Received: from dread.disaster.area (pa49-186-119-116.pa.vic.optusnet.com.au. [49.186.119.116]) by smtp.gmail.com with ESMTPSA id 17-20020a170902e9d100b001bb9883714dsm29527plk.143.2023.07.26.15.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 15:01:04 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qOmZ3-00AuS9-2i; Thu, 27 Jul 2023 08:01:01 +1000 Date: Thu, 27 Jul 2023 08:01:01 +1000 From: Dave Chinner To: Hao Xu Cc: io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, Wanpeng Li Subject: Re: [PATCH 3/7] add nowait parameter for iomap_seek() Message-ID: References: <20230726102603.155522-1-hao.xu@linux.dev> <20230726102603.155522-4-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726102603.155522-4-hao.xu@linux.dev> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Wed, Jul 26, 2023 at 06:25:59PM +0800, Hao Xu wrote: > From: Hao Xu > > Add a nowait parameter for iomap_seek(), later IOMAP_NOWAIT is set > according to this parameter's value. This shows the problem with adding booleans as flags to functions. Now there are -two- anonymous boolean flags to iomap_seek(), and reading the code becomes really hard to know what is actually being asked of iomap_seek(). This is another reason for not combining iomap_seek_data/hole()... -Dave. -- Dave Chinner david@fromorbit.com