From: Keith Busch <[email protected]>
To: Pankaj Raghav <[email protected]>
Cc: Keith Busch <[email protected]>,
[email protected], [email protected],
[email protected], [email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCHv2 1/4] block: bio-integrity: directly map user buffers
Date: Mon, 30 Oct 2023 08:54:07 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20231030144047.yrwejvdyyi4vo62m@localhost>
On Mon, Oct 30, 2023 at 03:40:47PM +0100, Pankaj Raghav wrote:
> > + int ret;
> > +
> > + /* if bvec is on the stack, we need to allocate a copy for the completion */
> > + if (nr_vecs <= UIO_FASTIOV) {
> > + copy_vec = kcalloc(sizeof(*bvec), nr_vecs, GFP_KERNEL);
> > + if (!copy_vec)
> > + return -ENOMEM;
> > + memcpy(copy_vec, bvec, nr_vecs * sizeof(*bvec));
> > + }
> > +
> > + buf = kmalloc(len, GFP_KERNEL);
> > + if (!buf)
> > + goto free_copy;
>
> ret is not set to -ENOMEM here.
Indeed, thanks for pointing that out. I'll wait a bit longer before
posting a v3.
next prev parent reply other threads:[~2023-10-30 14:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 18:19 [PATCHv2 0/4] block integrity: directly map user space addresses Keith Busch
2023-10-27 18:19 ` [PATCHv2 1/4] block: bio-integrity: directly map user buffers Keith Busch
[not found] ` <CGME20231030144050eucas1p12ede963088687846d9b02a27d7da525e@eucas1p1.samsung.com>
2023-10-30 14:40 ` Pankaj Raghav
2023-10-30 14:54 ` Keith Busch [this message]
2023-10-30 15:27 ` kernel test robot
2023-10-30 21:02 ` Kanchan Joshi
2023-10-30 21:25 ` Keith Busch
2023-10-31 0:13 ` kernel test robot
2023-10-31 2:46 ` kernel test robot
2023-11-06 5:48 ` Kanchan Joshi
2023-11-06 15:02 ` Keith Busch
2023-11-07 10:25 ` Kanchan Joshi
2023-11-07 15:08 ` Keith Busch
2023-11-08 12:15 ` Kanchan Joshi
2023-11-08 17:19 ` Keith Busch
2023-10-27 18:19 ` [PATCHv2 2/4] nvme: use bio_integrity_map_user Keith Busch
2023-10-27 18:19 ` [PATCHv2 3/4] iouring: remove IORING_URING_CMD_POLLED Keith Busch
2023-10-27 18:19 ` [PATCHv2 4/4] io_uring: remove uring_cmd cookie Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox