From: Christoph Hellwig <[email protected]>
To: Pavel Begunkov <[email protected]>
Cc: Christoph Hellwig <[email protected]>,
[email protected], Jens Axboe <[email protected]>,
Conrad Meyer <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH v2 4/7] block: introduce blk_validate_write()
Date: Fri, 23 Aug 2024 04:52:29 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Thu, Aug 22, 2024 at 01:36:10PM +0100, Pavel Begunkov wrote:
> It's used for other commands in the series, all of them are
> semantically "writes", or modifying data operations if that's
> better. How would you call it? Some blk_modify_validate_args,
> maybe?
Maybe just split the writability checks out and rename the rest
blk_validate_byte_range, that way the usage is pretty clearly
defined. Bonus points for writing a kerneldoc other other
comment header explaining it.
next prev parent reply other threads:[~2024-08-23 11:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 3:35 [PATCH v2 0/7] implement async block discards/etc. via io_uring Pavel Begunkov
2024-08-22 3:35 ` [PATCH v2 1/7] io_uring/cmd: expose iowq to cmds Pavel Begunkov
2024-08-22 3:35 ` [PATCH v2 2/7] io_uring/cmd: give inline space in request " Pavel Begunkov
2024-08-22 3:35 ` [PATCH v2 3/7] filemap: introduce filemap_invalidate_pages Pavel Begunkov
2024-08-22 6:37 ` Christoph Hellwig
2024-08-22 3:35 ` [PATCH v2 4/7] block: introduce blk_validate_write() Pavel Begunkov
2024-08-22 6:33 ` Christoph Hellwig
2024-08-22 12:36 ` Pavel Begunkov
2024-08-23 11:52 ` Christoph Hellwig [this message]
2024-08-22 3:35 ` [PATCH v2 5/7] block: implement async discard as io_uring cmd Pavel Begunkov
2024-08-22 6:46 ` Christoph Hellwig
2024-08-22 13:07 ` Pavel Begunkov
2024-08-23 11:59 ` Christoph Hellwig
2024-09-04 14:08 ` Pavel Begunkov
2024-08-22 3:35 ` [PATCH v2 6/7] block: implement async wire write zeroes Pavel Begunkov
2024-08-22 6:50 ` Christoph Hellwig
2024-08-22 13:09 ` Pavel Begunkov
2024-08-22 3:35 ` [PATCH v2 7/7] block: implement async secure erase Pavel Begunkov
2024-08-22 6:36 ` Christoph Hellwig
2024-08-22 12:36 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox