From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6092BAF9; Tue, 29 Oct 2024 15:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730216050; cv=none; b=YumoSNY+RQeA1U7PSfEjgGKAc+xiesqdpWujA5K17VLh0bKPXc0A+ETdUiOxPpfsjhqaFKntq3qaS8++WA4jhIFKoKM4nf8YRGZneMFIAGR7Mt2kcMTZxrqiMMPwWlz36QK9yg186oIX4xue5s8SbgQdpdWo2nRgkwYCkDW754A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730216050; c=relaxed/simple; bh=xGZIo//+rd5EBLgfh1sz1cn7TPzNY0b3vgJcMFqWpsw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BZcfYcfQ+cTMpmsQjdo24ievy9/Dttpue9WWV+fLJe0DfVvGBvFjMhbMWlnWPb+3SN1dokgLwpSTja7NPu11Ir1Xht6gGjg7oKPfwZsK5EZk8UkCEjKF3+GfP4bSkOME5ufwkZ/sNs4TGm35kjl/jd4P8oq+35PORYYyZivBx1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LKMZcW8s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LKMZcW8s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50A7DC4CECD; Tue, 29 Oct 2024 15:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730216050; bh=xGZIo//+rd5EBLgfh1sz1cn7TPzNY0b3vgJcMFqWpsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LKMZcW8sQFWxRSd3qgVIcjnTz4uwpTSxTNx15MUBFfRZkSQJ8Rl9WuB7YBxEPmV40 WHC02F4hb3r9/hQhfVTHnuuxWYFhfurX+RuGsUi1At+rmEmjj3mgKy82m1969vV9+1 F2HIjcPy6SNENoihV2/ZDUCcjFokBmMnl6Lb+IrYd+TwT+xcBhwCDhxyQ5Pn/ciHcZ 4IKjJZlFT31bKKU9bnR9ik3sf4d6QePkswE6uyo20RAnJHBWVVRN2fuN9Clmdp2Ri6 y6TFOHJPXLPx8FIeSFwRBvmM9yH/7H+b8Vy9f+JDF/v4Q8K9G6vVethOi/xt9oDq/S QVWr2m9MGX6Mg== Date: Tue, 29 Oct 2024 09:34:07 -0600 From: Keith Busch To: Christoph Hellwig Cc: Keith Busch , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, joshi.k@samsung.com, javier.gonz@samsung.com, bvanassche@acm.org, Hannes Reinecke Subject: Re: [PATCHv10 9/9] scsi: set permanent stream count in block limits Message-ID: References: <20241029151922.459139-1-kbusch@meta.com> <20241029151922.459139-10-kbusch@meta.com> <20241029152654.GC26431@lst.de> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241029152654.GC26431@lst.de> On Tue, Oct 29, 2024 at 04:26:54PM +0100, Christoph Hellwig wrote: > On Tue, Oct 29, 2024 at 08:19:22AM -0700, Keith Busch wrote: > > From: Keith Busch > > > > The block limits exports the number of write hints, so set this limit if > > the device reports support for the lifetime hints. Not only does this > > inform the user of which hints are possible, it also allows scsi devices > > supporting the feature to utilize the full range through raw block > > device direct-io. > > > > Reviewed-by: Bart Van Assche > > Reviewed-by: Hannes Reinecke > > Signed-off-by: Keith Busch > > Despite the reviews this is still incorrect. The permanent streams have > a relative data temperature associated with them as pointed out last > round and are not arbitrary write stream contexts despite (ab)using > the SBC streams facilities. So then don't use it that way? I still don't know what change you're expecting to happen with this feedback. What do you want the kernel to do differently here?