[bug report] fio failed with --fixedbufs

[bug report] fio failed with --fixedbufs

[Guangwu Zhang]

Hi,

Get the fio error like below, please have a look if something wrong  here,
can not reproduce it if remove "--fixedbufs".

Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
Commit: 51b3526f50cf5526b73d06bd44a0f5e3f936fb01

# fio --numjobs=1 --ioengine=io_uring_cmd --runtime='300'
--size='300G' --filename=/dev/ng1n1 --rw='randrw' --name='fio_test'
--iodepth=64 --bs=8k --group_reporting=1 --cmd_type='nvme'
--md_per_io_size='4K'  --fixedbufs
fio_test: (g=0): rw=randrw, bs=(R) 8192B-8192B, (W) 8192B-8192B, (T)
8192B-8192B, ioengine=io_uring_cmd, iodepth=64
fio-3.38-13-gf241
Starting 1 process
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=314721697792, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=278937288704, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=211560456192, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=166314262528, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=194210742272, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=314948960256, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=4652392448, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=72851734528, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=105412198400, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=269298982912, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=217188352000, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=182140698624, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=306352644096, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=123246698496, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=4156350464, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=240869728256, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=257956913152, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=157641924608, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=248337874944, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=192326352896, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=59785117696, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=159764578304, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=113134592000, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=162308825088, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=150173917184, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=14641209344, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=271883075584, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=55705149440, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=258477580288, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=34678931456, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=311085285376, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=129028251648, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=195086909440, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=300242763776, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=310458490880, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=91683938304, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=142651342848, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=225977384960, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=271599779840, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=52967882752, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=303015387136, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=273026170880, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=318919712768, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=185858064384, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=291365412864, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=170794999808, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=31619899392, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=240495542272, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=185245155328, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=65555390464, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=290169774080, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=199942692864, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=11003101184, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=147007119360, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=48097304576, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=178375688192, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=138726440960, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=239489859584, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=142543421440, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=73279242240, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: read
offset=16768991232, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=252541501440, buflen=8192
fio: io_u error on file /dev/ng1n1: Bad address: write
offset=269492428800, buflen=8192
fio: pid=112524, err=14/file:io_u.c:1976, func=io_u error, error=Bad address

fio_test: (groupid=0, jobs=1): err=14 (file:io_u.c:1976, func=io_u
error, error=Bad address): pid=112524: Mon Nov 11 02:05:53 2024
  write: IOPS=35.0k, BW=8000KiB/s (8192kB/s)(8192B/1msec); 0 zone resets
    slat (nsec): min=576, max=20959, avg=1331.14, stdev=3417.56
    clat (nsec): min=59294, max=59294, avg=59294.00, stdev= 0.00
     lat (nsec): min=80253, max=80253, avg=80253.00, stdev= 0.00
    clat percentiles (nsec):
     |  1.00th=[59136],  5.00th=[59136], 10.00th=[59136], 20.00th=[59136],
     | 30.00th=[59136], 40.00th=[59136], 50.00th=[59136], 60.00th=[59136],
     | 70.00th=[59136], 80.00th=[59136], 90.00th=[59136], 95.00th=[59136],
     | 99.00th=[59136], 99.50th=[59136], 99.90th=[59136], 99.95th=[59136],
     | 99.99th=[59136]
  lat (usec)   : 100=1.56%
  cpu          : usr=0.00%, sys=0.00%, ctx=0, majf=0, minf=9
  IO depths    : 1=1.6%, 2=3.1%, 4=6.2%, 8=12.5%, 16=25.0%, 32=50.0%, >=64=1.6%
     submit    : 0=0.0%, 4=100.0%, 8=0.0%, 16=0.0%, 32=0.0%, 64=0.0%, >=64=0.0%
     complete  : 0=0.0%, 4=66.7%, 8=0.0%, 16=0.0%, 32=0.0%, 64=33.3%, >=64=0.0%
     issued rwts: total=29,35,0,0 short=0,0,0,0 dropped=0,0,0,0
     latency   : target=0, window=0, percentile=100.00%, depth=64

Run status group 0 (all jobs):
  WRITE: bw=8000KiB/s (8192kB/s), 8000KiB/s-8000KiB/s
(8192kB/s-8192kB/s), io=8192B (8192B), run=1-1msec




-- 
Guangwu Zhang
Thanks

Re: [bug report] fio failed with --fixedbufs

[Ming Lei]

Hi Guangwu,

On Mon, Nov 11, 2024 at 03:20:22PM +0800, Guangwu Zhang wrote:
> Hi,
> 
> Get the fio error like below, please have a look if something wrong  here,
> can not reproduce it if remove "--fixedbufs".
> 
> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> Commit: 51b3526f50cf5526b73d06bd44a0f5e3f936fb01
> 

The issue should be fixed by the following patch:

diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
index e7723759cb23..401c861ebc8e 100644
--- a/io_uring/uring_cmd.c
+++ b/io_uring/uring_cmd.c
@@ -221,6 +221,7 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
                struct io_ring_ctx *ctx = req->ctx;
                struct io_rsrc_node *node;

+               req->buf_index = READ_ONCE(sqe->buf_index);
                node = io_rsrc_node_lookup(&ctx->buf_table, req->buf_index);
                if (unlikely(!node))
                        return -EFAULT;



Thanks,
Ming

Re: [bug report] fio failed with --fixedbufs

[Guangwu Zhang]

OK, will test the patch and feedback result.

Ming Lei <ming.lei@redhat.com> 于2024年11月11日周一 15:50写道：
>
> Hi Guangwu,
>
> On Mon, Nov 11, 2024 at 03:20:22PM +0800, Guangwu Zhang wrote:
> > Hi,
> >
> > Get the fio error like below, please have a look if something wrong  here,
> > can not reproduce it if remove "--fixedbufs".
> >
> > Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
> > Commit: 51b3526f50cf5526b73d06bd44a0f5e3f936fb01
> >
>
> The issue should be fixed by the following patch:
>
> diff --git a/io_uring/uring_cmd.c b/io_uring/uring_cmd.c
> index e7723759cb23..401c861ebc8e 100644
> --- a/io_uring/uring_cmd.c
> +++ b/io_uring/uring_cmd.c
> @@ -221,6 +221,7 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
>                 struct io_ring_ctx *ctx = req->ctx;
>                 struct io_rsrc_node *node;
>
> +               req->buf_index = READ_ONCE(sqe->buf_index);
>                 node = io_rsrc_node_lookup(&ctx->buf_table, req->buf_index);
>                 if (unlikely(!node))
>                         return -EFAULT;
>
>
>
> Thanks,
> Ming
>


-- 
Guangwu Zhang
Thanks