From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE43D2E3EB for ; Mon, 18 Nov 2024 23:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731972700; cv=none; b=CsTd641K09IoX2VFtYjVkDNwCrFw5dd1T/wP3+xwpgjvcGp4xdFgk+Jz7l6L16nMUGLLyTH8D/GYHsX84faUC32vfVHJGzkaSIY4x3Fp3K3wbQKNB5S2IZHqm66vWCagvfJRhW+ljgSSfZhat8V/oikCZRInbHoNNm56k+3ME2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731972700; c=relaxed/simple; bh=RSjFiAdJC1674a14jNvmlIMN52hCke/iMrfnmXV6SQg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EXI7F0t9Bux2qm51CpEdjzQPi/ROy/pXQAPaqRd3xIkJ+XM2A7UhIrqbIBkgmRuzYEBnBrsZwJklzCPjtha+i9cyhUMKGcln8R1K/rwbe1upfSS8MYD+64ChQw/SJu1RNe/Ta3y5lZ+tbmD+D/LKkqBXqIFWD43mizZ/VQVM6Cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JZs3cTCq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JZs3cTCq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B6ADC4CECC; Mon, 18 Nov 2024 23:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731972699; bh=RSjFiAdJC1674a14jNvmlIMN52hCke/iMrfnmXV6SQg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JZs3cTCqF5B5lxXA9+bWuuP44LKd4CWIOBR2A6NmVG56O8SdHxZbEajmR8ShXc4xg Yjk5PG0q7PQsE5iv35XSK2UAyHAyVBbn0D+RDJ5zQlTBTGmSDNigfOMNmkL1mnve+L e+j5rVd5GT8VWw0LF9odfSwBJ5svSDMz6xJetrhLv1dsuwwaMr2DjrsOeoPfjedT+B vl6LuQhxWkw6NRj6VuZTjKgSOfOdkev9YWI6E53VV9edud4q44SoOZiDB/j6UzTyY7 CBsep6D1RlOrsV1QzptMJHctDeQe0e4UqAkHDbwj5q4WXzDcaQ2hFt/pI/A/njIUnC 43HpIstHuU3cQ== Date: Mon, 18 Nov 2024 17:24:19 -0500 From: Sasha Levin To: Jens Axboe Cc: Linus Torvalds , io-uring , tglx@linutronix.de Subject: Re: [GIT PULL] io_uring changes for 6.13-rc1 Message-ID: References: Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Mon, Nov 18, 2024 at 05:06:46PM -0500, Sasha Levin wrote: >Hi Jens, Thomas, > >On Mon, Nov 18, 2024 at 07:22:59AM -0700, Jens Axboe wrote: >>hexue (1): >> io_uring: add support for hybrid IOPOLL > >After merging of this pull request into linus-next, I've started seeing >build errors: > >/builds/linux/io_uring/rw.c: In function 'io_hybrid_iopoll_delay': >/builds/linux/io_uring/rw.c:1179:2: error: implicit declaration of function 'hrtimer_init_sleeper_on_stack'; did you mean 'hrtimer_setup_sleeper_on_stack'? [-Werror=implicit-function-declaration] > hrtimer_init_sleeper_on_stack(&timer, CLOCK_MONOTONIC, mode); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > hrtimer_setup_sleeper_on_stack > >This is because 01ee194d1aba ("io_uring: add support for hybrid IOPOLL") >adds a call to hrtimer_init_sleeper_on_stack() which was removed earlier >today in Thomas's PR[1], specifically in commit f3bef7aaa6c8 >("hrtimers: Delete hrtimer_init_sleeper_on_stack()"). Linus, Looks like this is a simple s/hrtimer_init_sleeper_on_stack/hrtimer_setup_sleeper_on_stack , so this issue could be addressed by replacing the new call with hrtimer_setup_sleeper_on_stack() either in the io_uring or the timers/core merge, whichever you pull last. -- Thanks, Sasha