From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: Christian Mazakas <[email protected]>
Subject: Re: [PATCH 1/1] io_uring/timeout: fix multishot updates
Date: Sat, 4 Jan 2025 15:12:11 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 1/4/25 1:44 PM, Pavel Begunkov wrote:
> On 1/4/25 18:39, Jens Axboe wrote:
>> On 1/4/25 11:29 AM, Pavel Begunkov wrote:
>>> After update only the first shot of a multishot timeout request adheres
>>> to the new timeout value while all subsequent retries continue to use
>>> the old value. Don't forget to update the timeout stored in struct
>>> io_timeout_data.
>>
>> Nice find!
>>
>> Do we have a test case that can go into liburing for this too?
>
> Christian has a patch, I assume he's going to send it
>
> https://github.com/axboe/liburing/issues/1316
> https://github.com/axboe/liburing/commit/3a5919aef666bdf0202c76918dbb85f1a6db9a32
Perfect.
--
Jens Axboe
next prev parent reply other threads:[~2025-01-04 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 18:29 [PATCH 1/1] io_uring/timeout: fix multishot updates Pavel Begunkov
2025-01-04 18:39 ` Jens Axboe
2025-01-04 20:44 ` Pavel Begunkov
2025-01-04 22:12 ` Jens Axboe [this message]
2025-01-04 18:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox