From: Jens Axboe <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH 2/6] iomap: add IOMAP_DIO_INLINE_COMP
Date: Thu, 20 Jul 2023 10:19:59 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 7/19/23 10:51?PM, Christoph Hellwig wrote:
>> - if (dio->flags & IOMAP_DIO_WRITE) {
>> - struct inode *inode = file_inode(iocb->ki_filp);
>> -
>> - WRITE_ONCE(iocb->private, NULL);
>> - INIT_WORK(&dio->aio.work, iomap_dio_complete_work);
>> - queue_work(inode->i_sb->s_dio_done_wq, &dio->aio.work);
>> - } else {
>> + if (dio->flags & IOMAP_DIO_INLINE_COMP) {
>> WRITE_ONCE(iocb->private, NULL);
>> iomap_dio_complete_work(&dio->aio.work);
>> + goto release_bio;
>> }
>
> I would have properly just structured the code to match this in the
> lat path with a
>
> if (!(dio->flags & IOMAP_DIO_WRITE)) {
>
> so that this becomes trivial. But that's just nitpicking and the
> result looks good to me.
Ends up being done that way anyway with the rework of patch 1 to put the
non-write side first, so that's what it looks like now in v3.
--
Jens Axboe
next prev parent reply other threads:[~2023-07-20 16:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 19:54 [PATCHSET v3 0/6] Improve async iomap DIO performance Jens Axboe
2023-07-19 19:54 ` [PATCH 1/6] iomap: cleanup up iomap_dio_bio_end_io() Jens Axboe
2023-07-20 4:50 ` Christoph Hellwig
2023-07-20 16:13 ` Jens Axboe
2023-07-19 19:54 ` [PATCH 2/6] iomap: add IOMAP_DIO_INLINE_COMP Jens Axboe
2023-07-20 4:51 ` Christoph Hellwig
2023-07-20 16:19 ` Jens Axboe [this message]
2023-07-19 19:54 ` [PATCH 3/6] iomap: treat a write through cache the same as FUA Jens Axboe
2023-07-20 4:54 ` Christoph Hellwig
2023-07-20 16:23 ` Jens Axboe
2023-07-19 19:54 ` [PATCH 4/6] fs: add IOCB flags related to passing back dio completions Jens Axboe
2023-07-20 5:01 ` Christoph Hellwig
2023-07-20 16:25 ` Jens Axboe
2023-07-19 19:54 ` [PATCH 5/6] io_uring/rw: add write support for IOCB_DIO_DEFER Jens Axboe
2023-07-19 19:54 ` [PATCH 6/6] iomap: support IOCB_DIO_DEFER Jens Axboe
2023-07-20 4:59 ` Christoph Hellwig
2023-07-20 16:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox