From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4CCC43603 for ; Fri, 20 Dec 2019 23:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21280206EC for ; Fri, 20 Dec 2019 23:51:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="ykJu8gvY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbfLTXvJ (ORCPT ); Fri, 20 Dec 2019 18:51:09 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:42343 "EHLO mail-pl1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbfLTXvJ (ORCPT ); Fri, 20 Dec 2019 18:51:09 -0500 Received: by mail-pl1-f169.google.com with SMTP id p9so4764307plk.9 for ; Fri, 20 Dec 2019 15:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NKQ9URZBMeV3OPseAAh2Xx7y2pXyxLatIKtNl8iLvXQ=; b=ykJu8gvYo2ySI4MYq3KAx12I/84YrqF+Q/U5WMmy9QswF5KWC7Km1ht1FtGvNaAqEP O5N9mcr7Ry87YOOCeMm9G9FT4U2Eg8KXvUxER0cexg2PiLXMO8kzbyibp6yHj99A0BwQ azvWMwgMPEzz53V3OcaFGUZMscgQ49MExbyF4PTQYnrMpJNaDUSPsxshj/pv3lDgiSEa V6iwl5I4A5vmr+Ob3uN9MzIuG2rz8qbK9VqN9mLJejdnI3ZW3+2VKhK3LRj+FC/uePhi Swb8KNcr8jc974+Q3z6dOxdd6nhs7IAAlnnRfXigkKsfolnY0ljiBl0xJMN8YmjPXtYj 1Gjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NKQ9URZBMeV3OPseAAh2Xx7y2pXyxLatIKtNl8iLvXQ=; b=j9Qg78ZsV3Jp4tzeBtDUsBZU7pC42p1MYm5VMkBxfAN5la4Njwm+LCkO5m8feWrKKo KHxbw+6zU2o0si6QtqDw+hPrmKfgGC38L2WTZcELmOVNJOJvUHsGUM/lOJUoCDZH1QaZ ePduzYHXwEbP3BQxHOMLCgWrzYL9pAuZQ86Q3L1BLa9XLM36TB5VQL3HG3Jow6nP4a6P Qngf6Gcp/IwxVW0swB6SeFfQ3tQwhJcahvIGQR2bGeIJhiyvfL0Z5W+SmUVci6ToyJMd vC8YLx7j6bQkaZ03NBvav6PDIXpD4SR5D8kAN3hZ9nKe33kXwzyu0GiFpCewwPVOQM5H UpOQ== X-Gm-Message-State: APjAAAUofkvIxGCF17HZQIHjkFJWXQFHGO9yyUq9PeQdKKMgr5QCBjZ7 sIM2gDCagt97rgnLiuaQUSLP5g== X-Google-Smtp-Source: APXvYqzmkZWiV7MicyHExsLOg3UvxPLhXwAkPmhB5mHQM5D5YzarwPE7bcTHy/sqhKiuGY4VEVe9RA== X-Received: by 2002:a17:902:76c9:: with SMTP id j9mr8890271plt.21.1576885852697; Fri, 20 Dec 2019 15:50:52 -0800 (PST) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id w38sm13024578pgk.45.2019.12.20.15.50.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2019 15:50:52 -0800 (PST) Subject: Re: [PATCH][next] io_uring: fix missing error return when percpu_ref_init fails To: Colin Ian King , Alexander Viro , io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191220233322.13599-1-colin.king@canonical.com> <398f514a-e2ce-8b4f-16cf-4edeec5fa1e7@kernel.dk> From: Jens Axboe Message-ID: Date: Fri, 20 Dec 2019 16:50:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 12/20/19 4:49 PM, Colin Ian King wrote: > On 20/12/2019 23:48, Jens Axboe wrote: >> On 12/20/19 4:33 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently when the call to percpu_ref_init fails ctx->file_data is >>> set to null and because there is a missing return statement the >>> following statement dereferences this null pointer causing an oops. >>> Fix this by adding the missing -ENOMEM return to avoid the oops. >> >> Nice, thanks! I'm guessing I didn't have the necessary magic debug >> options to allow failure injection for failing. > > Fortunately we have Coverity to the rescue :-) Indeed! -- Jens Axboe