From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 911711891CA; Wed, 3 Jul 2024 18:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720032314; cv=none; b=DY2BNmIC7IDCF/j+IRTWNlYTM7o/ntdn8qg4A4Fmng/cu44qmYtAR2ORoKBJjdCgnfMPrjd0Etn5pnfYI+1kAfaduPeNVGK+xj+yzdybRgNZrvlMT78NWw48onvsjxUVbsOt1d8IL51eIVIXI3AcV8KwkysXZabP8PgoJMBpM3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720032314; c=relaxed/simple; bh=1HAUPmxyK03Kz683iTuisW6s29R1cGrirF7oFDboFUA=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=jm4xodiS8tXrqnGT3U3yq9AFRE5Y3uSaw0gaB4ASiuom+F2Jab48UalaplWHAWV7SbqIjBSrsdopvoqQIOa04erw8s/gxGZ/OKeOKHUOdrE3mvmXvJ0V9/Oh0TJLFlePxiZzTPadcsL4tSWAnrPc77JE8b+2vaE5PAjtey6mX9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=uQ4YFtuj; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=henDsDRR; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="uQ4YFtuj"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="henDsDRR" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id C074213800AE; Wed, 3 Jul 2024 14:45:11 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 03 Jul 2024 14:45:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1720032311; x=1720118711; bh=EFR6lVRiOK NkSmgerDmIGmryUFpvxrTuGj4sDMv6LuM=; b=uQ4YFtujx0iAMZbEkSSPfBw//w Aur1tTE1Qbso8Qh56qTd1bnaFbQo+kmB/NGJqeOI2XV8HsRJMG7843ABjamNxMnj M4ovl7iWTLqMKDf2Q+1qH4ds7PtTS1k4dWr7lrJAGnaAp0nzlTRdMwTZJ3bSuQwv XWrABZJ5x5z4SfnBbh9+UXQ9KBDGVU6Wkx0r2n4+7EjwdxE7NNrlH3uFbdX8xl3Q UdD0H4f5JegElE8jF7PD8GeN0dBo9laTfrXToPEAEHuw8+0lWgZU1n+bC8lSzNDx U7ZoLL4eBDJIlXyEXratlmB4J0ydxZwMErKZKG/kyRXNsl2E0/j8dx8madKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1720032311; x=1720118711; bh=EFR6lVRiOKNkSmgerDmIGmryUFpv xrTuGj4sDMv6LuM=; b=henDsDRR8/F745TtI0Y1tC5+Nc6H9jEggKnNn3OHRM2r 3OHlEMBEmZwhK6LSWkqi/LCQQ4dvYVESR5RBf+wOQwG8WBmlISDBJHj9lf3SRNDk 9gs+9SvVRgEvuhkmt/SnNwvVLztalAClHlseHc2xI0lBg1pps36ss01EQogXAmmF CX7dTP3DChLjFm1OIVXZPxe/bSuSeB1CoAQiu8PdhCujII+9uVULHQxu2z4FGDaQ hh8pCxPRm/e2WoKoEJGoyiOz6z90bOKiR90BdsH9jlFQJx9dNrY2uyM/jcCtAQi1 L6MfDNZmczYPctWOZkIEkQbAHTJhwySVDK2zduwLPA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejgdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E5373B6008D; Wed, 3 Jul 2024 14:45:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-566-g3812ddbbc-fm-20240627.001-g3812ddbb Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20240625110029.606032-1-mjguzik@gmail.com> <20240625110029.606032-3-mjguzik@gmail.com> <30907b42d5eee6d71f40b9fc3d32ae31406fe899.camel@xry111.site> <1b5d0840-766b-4c3b-8579-3c2c892c4d74@app.fastmail.com> <8f2d356d-9cd6-4b06-8e20-941e187cab43@app.fastmail.com> <20240703-bergwacht-sitzung-ef4f2e63cd70@brauner> <8b6d59ffc9baa57fee0f9fa97e72121fd88cf0e4.camel@xry111.site> Date: Wed, 03 Jul 2024 20:44:50 +0200 From: "Arnd Bergmann" To: "Linus Torvalds" , "Xi Ruoyao" Cc: "Christian Brauner" , "Xi Ruoyao" , "Andreas K Huettel" , "Huacai Chen" , "Mateusz Guzik" , "Alexander Viro" , "Jan Kara" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, "Jens Axboe" , loongarch@lists.linux.dev Subject: Re: [PATCH 2/2] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...) Content-Type: text/plain On Wed, Jul 3, 2024, at 19:40, Linus Torvalds wrote: > On Wed, 3 Jul 2024 at 10:30, Xi Ruoyao wrote: >> >> struct stat64 { >> >> // ... >> >> int st_atime; /* Time of last access. */ > > Oh wow. Shows just *how* long ago that was - and how long ago I looked > at 32-bit code. Because clearly, I was wrong. > > I guess it shows how nobody actually cares about 32-bit any more, at > least in the 2037 sense. > > The point stands, though - statx isn't a replacement for existing binaries. We had long discussions about adding another stat()/fstat() variant with 64-bit timestamps from 2012 to 2017, the result was that we mandated that a libc implementation with 64-bit time_t must only use statx() and not fall back to the time32 syscalls on kernels that are new enough to have statx(). This is both for architectures that were introduced after time64 support was added (riscv32 and the glibc port for arc), and for userspace builds that are explicitly using time64 syscalls only. That may have been a mistake in hindsight, or it may have been the right choice, but the thing is that if we now decide that 32-bit userspace can not rely on statx() to be available, then we need to introduce one or two new system calls. Arnd