public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jiufei Xue <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH] io_uring: don't set REQ_F_NOWAIT for regular files opend O_NONBLOCK
Date: Mon, 1 Jun 2020 11:26:36 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Hi Jens,

On 2020/5/29 下午10:20, Jens Axboe wrote:
> On 5/29/20 1:18 AM, Jiufei Xue wrote:
>> When read from a regular file that was opened O_NONBLOCK, it will
>> return EAGAIN if the page is not cached, which is not expected and
>> fails the application.
>>
>> Applications written before expect that the open flag O_NONBLOCK has
>> no effect on a regular file.
>>
>> Fix this by not setting REQ_F_NOWAIT for regular files.
> 
> Agree, this also matches what we do for sockets. You need to update
> the comment as well, though.
> 
Reading from an O_NONBLOCK socket will return EAGAIN if there isn't any
unread data in the buffer which is expected.So I don't know what is your
meaning about that. Do you mean the recv() interface? 

Regards,
Jiufei



  reply	other threads:[~2020-06-01  3:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  7:18 [PATCH] io_uring: don't set REQ_F_NOWAIT for regular files opend O_NONBLOCK Jiufei Xue
2020-05-29 14:20 ` Jens Axboe
2020-06-01  3:26   ` Jiufei Xue [this message]
2020-06-10  6:16     ` Jiufei Xue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a35e60c6-4df2-cfd8-e62c-4a1e21c85e22@linux.alibaba.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox