From: Jens Axboe <axboe@kernel.dk>
To: Yitang Yang <yi1tang.yang@gmail.com>
Cc: krisman@suse.de, io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring/rw: fix missing ERESTARTSYS conversion in read paths
Date: Tue, 21 Jul 2026 10:32:40 -0600 [thread overview]
Message-ID: <a493a932-46e8-4253-81f9-2c849c7b2ff8@kernel.dk> (raw)
In-Reply-To: <20260720114116.21830-1-yi1tang.yang@gmail.com>
On 7/20/26 5:41 AM, Yitang Yang wrote:
> Both read and write may receive internal restart error codes from
> the filesystem layer and should be converted to -EINTR. However,
> when multishot read support was added, the error code normalization
> was lost for both io_read() and io_read_mshot().
>
> Extract the conversion into io_fixup_restart_res() and apply it
> in all three locations: io_rw_done(), io_read(), and io_read_mshot().
How was this found? Reason I ask is that I wonder if this is even
necessary in the first place. If you found this because of an issue
you ran into, then that answers that question clearly (yes we need it).
But if this some LLM find, then that's an entirely different story.
--
Jens Axboe
next prev parent reply other threads:[~2026-07-21 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 11:41 [PATCH] io_uring/rw: fix missing ERESTARTSYS conversion in read paths Yitang Yang
2026-07-21 16:32 ` Jens Axboe [this message]
2026-07-22 3:08 ` Yitang Yang
2026-07-22 10:28 ` Jens Axboe
2026-07-22 10:32 ` Jens Axboe
2026-07-22 12:36 ` Yitang Yang
2026-07-22 13:37 ` Jens Axboe
2026-07-23 12:46 ` [PATCH liburing] test: add rw-restart-ret regression test Yitang Yang
2026-07-22 12:45 ` [PATCH v2] io_uring/rw: fix missing ERESTARTSYS conversion in read paths Yitang Yang
2026-07-22 13:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a493a932-46e8-4253-81f9-2c849c7b2ff8@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=krisman@suse.de \
--cc=yi1tang.yang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox