From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660C614EC55 for ; Wed, 20 Nov 2024 16:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732121370; cv=none; b=pcibWt4IxCe6+E6Rh55OVxXh3ZsWoZnDNJe8DFV6D5SiWi5TYuXFC1LF+ANpVbGw9A3DW/kt1E7PFjQ32AvBvLWT5WG9bSd284jZPVNUvww6aTJqpIjNLj7DQbTjtn7jJ9h7k9maNB2QYCZFwButG9EZLy5TbNCnvKqyiuc7E4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732121370; c=relaxed/simple; bh=uTcW/OXkP/DVlYo+bDrcBN3tSEWrHeyWrIUDmBqXaFE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=dPd1PH2B2M9rqCZsqGR7+v7g6C5beiSeTAbwftjSGhoeQafEBRYTxZPmVKQ98MznxCWp6TXCXtYf06sUCWWvClOEwqXyoGub6C0EgBYXKu95dNVtpBlXonArqx/vbvisF52EDksBnVf43P+yVSUC1UQbwuI9Y7v74AEdc58iZ18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=iH+2mqbZ; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="iH+2mqbZ" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3e612437c09so4014961b6e.2 for ; Wed, 20 Nov 2024 08:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1732121366; x=1732726166; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=NSXJWfERfexWCJawwZmjuxM0TstuZH3uBUhDK90vA7c=; b=iH+2mqbZjb+fIDp7kJsH2ypmZgl58Ju0yj5myVjpWTmbRMg4v3EdXuL6kKDee/GaHo ICyahGcBCgltgZMOo7b3TIQHlUsY2tPbo3YFIDDFgLF7DNCYPmUezWKug4j6wI/uETv8 Gh2aAx8BRpnPLHuUtAn8S8nCyb5ItA+ZKY2gPiucmE+Nn4qSaCf2OWS8ABCv/N5O4eWt P3hh8oaZiqsHqH5M2UVm6kenJSi/npXnR2oKqbkJ5z2cAIAfGx6Os78EDiYJ8Bp8geQx 9h1v9MVZimdfNrDsLca9mJuF2wLpfE/GdcwBZ/VF7PJ3TGwGawH3Rm5o1OZf9PgkDk7M hzeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732121366; x=1732726166; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NSXJWfERfexWCJawwZmjuxM0TstuZH3uBUhDK90vA7c=; b=VG4g9+MuUicOw5tDL+3l4K5xp7okwZwHArESXjDsoAmxoJpDWFfXRGEpRFMduBkXLr CXHiHkF5DkxIxGDm/ss6z8i1a91mM/UT/7R8VhIh0Cp7CKtb3TrD5FojLYprOTyjpVeQ BP+QTbl1ZRqqaPtp+/DVYmeZ0x3qTmt0adsFl6JiES48r8RCTEKl7HiiZgtX4WLTFS/6 Zd5R8NJxVciXBkY7oRsPR8Q8WoR2yTT7iwbwl1OCrUhd91d6K1w6DX5RiK7kbFGkBME9 7q78DoefPsLURfP1pBy3cDWChNiRqAHnk414DRPh2hf4ag/BTL12MEC52hKsOKmKE17Q rNOA== X-Forwarded-Encrypted: i=1; AJvYcCXZsR1Lr1jit+TRR/vp9S+dlXWLIAmjf+15iM8NKwixSPJ7UKTxM+Obtosef7ItVtQcAkofMpSXDw==@vger.kernel.org X-Gm-Message-State: AOJu0YwhrfQfg8Z4er2+sdKvE1oWbEw+j7+2cTOUzsfv1N/JdRDIZLun aBvqPyA8RyYkE66UFMM8uzqAWEcaBRrOqly7EnXbgVqQ9nwBB3MbAvcUU30a0pc= X-Google-Smtp-Source: AGHT+IFvK3/eQntYouSJyiYiPaa68TxNVW7hxbWFCD0pCaluEsNtDf75KWjGPnoR0UXIzEf0uqVYxQ== X-Received: by 2002:a05:6808:2110:b0:3e6:58cd:fb22 with SMTP id 5614622812f47-3e7eb7130bemr3258601b6e.10.1732121365929; Wed, 20 Nov 2024 08:49:25 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e7bccfb837sm4317101b6e.1.2024.11.20.08.49.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2024 08:49:25 -0800 (PST) Message-ID: Date: Wed, 20 Nov 2024 09:49:24 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] io_uring: use sizeof for io_issue_defs[IORING_OP_URING_CMD].async_size To: Mark Harmstone , linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org References: <20241120160231.1106844-1-maharmstone@fb.com> <20241120160231.1106844-2-maharmstone@fb.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20241120160231.1106844-2-maharmstone@fb.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/20/24 9:02 AM, Mark Harmstone wrote: > Correct the value of io_issue_defs[IORING_OP_URING_CMD].async_size so > that it is derived from the size of the struct rather than being > calculated. You should probably just fold this with patch 1, where the type is changed. -- Jens Axboe