From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Mina Almasry <almasrymina@google.com>
Cc: andrew+netdev@lunn.ch, asml.silence@gmail.com, axboe@kernel.dk,
corbet@lwn.net, davem@davemloft.net, donald.hunter@gmail.com,
dsahern@kernel.org, dw@davidwei.uk, edumazet@google.com,
eperezma@redhat.com, horms@kernel.org, hramamurthy@google.com,
io-uring@vger.kernel.org, jasowang@redhat.com,
jeroendb@google.com, jhs@mojatatu.com, kuba@kernel.org,
kuniyu@amazon.com, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, mst@redhat.com,
ncardwell@google.com, netdev@vger.kernel.org, pabeni@redhat.com,
pctammela@mojatatu.com, sdf@fomichev.me, sgarzare@redhat.com,
shuah@kernel.org, skhawaja@google.com, stefanha@redhat.com,
victor@mojatatu.com, virtualization@lists.linux.dev,
willemb@google.com, xuanzhuo@linux.alibaba.com
Subject: Re: [PATCH net-next v12 1/9] netmem: add niov->type attribute to distinguish different net_iov types
Date: Sat, 26 Apr 2025 08:31:10 +0200 [thread overview]
Message-ID: <a70511f2-70b2-4f48-94df-c55c179ce488@wanadoo.fr> (raw)
In-Reply-To: <20250425204743.617260-2-almasrymina@google.com>
Hi,
below a few nitpicks in case of a v13.
Le 25/04/2025 à 22:47, Mina Almasry a écrit :
> Later patches in the series adds TX net_iovs where there is no pp
> associated, so we can't rely on niov->pp->mp_ops to tell what is the
> type of the net_iov.
>
> Add a type enum to the net_iov which tells us the net_iov type.
>
> Signed-off-by: Mina Almasry <almasrymina@google.com>
>
> ---
Nitpick: unneeded empty need line above ---?
...
> +enum net_iov_type {
> + NET_IOV_DMABUF,
> + NET_IOV_IOURING,
> +
> + /* Force size to unsigned long to make the NET_IOV_ASSERTS below pass.
> + */
> + NET_IOV_MAX = ULONG_MAX,
Nitpick: unneeded trailing , after such a terminator.
> +};
...
CJ
next prev parent reply other threads:[~2025-04-26 6:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 20:47 [PATCH net-next v12 0/9] Device memory TCP TX Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 1/9] netmem: add niov->type attribute to distinguish different net_iov types Mina Almasry
2025-04-26 6:31 ` Christophe JAILLET [this message]
2025-04-25 20:47 ` [PATCH net-next v12 2/9] net: add get_netmem/put_netmem support Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 3/9] net: devmem: TCP tx netlink api Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 4/9] net: devmem: Implement TX path Mina Almasry
2025-04-26 15:12 ` Christophe JAILLET
2025-04-25 20:47 ` [PATCH net-next v12 5/9] net: add devmem TCP TX documentation Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 6/9] net: enable driver support for netmem TX Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 7/9] gve: add netmem TX support to GVE DQO-RDA mode Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 8/9] net: check for driver support in netmem TX Mina Almasry
2025-04-25 20:47 ` [PATCH net-next v12 9/9] selftests: ncdevmem: Implement devmem TCP TX Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a70511f2-70b2-4f48-94df-c55c179ce488@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=io-uring@vger.kernel.org \
--cc=jasowang@redhat.com \
--cc=jeroendb@google.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=sdf@fomichev.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=stefanha@redhat.com \
--cc=victor@mojatatu.com \
--cc=virtualization@lists.linux.dev \
--cc=willemb@google.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox