From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF42C4338F for ; Mon, 9 Aug 2021 21:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FE8D60EE7 for ; Mon, 9 Aug 2021 21:24:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234772AbhHIVYj (ORCPT ); Mon, 9 Aug 2021 17:24:39 -0400 Received: from cloud48395.mywhc.ca ([173.209.37.211]:37728 "EHLO cloud48395.mywhc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234584AbhHIVYi (ORCPT ); Mon, 9 Aug 2021 17:24:38 -0400 X-Greylist: delayed 3916 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Aug 2021 17:24:38 EDT Received: from modemcable064.203-130-66.mc.videotron.ca ([66.130.203.64]:54428 helo=[192.168.1.179]) by cloud48395.mywhc.ca with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mDBjg-0002K4-PT; Mon, 09 Aug 2021 16:19:00 -0400 Message-ID: Subject: Re: [PATCH 2/3] io-wq: fix no lock protection of acct->nr_worker From: Olivier Langlois To: Jens Axboe , Hao Xu Cc: io-uring , Pavel Begunkov , Joseph Qi Date: Mon, 09 Aug 2021 16:19:00 -0400 In-Reply-To: <5f4b7861-de78-8b45-644f-3a9efe3af964@kernel.dk> References: <20210805100538.127891-1-haoxu@linux.alibaba.com> <20210805100538.127891-3-haoxu@linux.alibaba.com> <1f795e93-c137-439e-b02c-b460cb38bb14@linux.alibaba.com> <5f4b7861-de78-8b45-644f-3a9efe3af964@kernel.dk> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud48395.mywhc.ca X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - olivierlanglois.net X-Get-Message-Sender-Via: cloud48395.mywhc.ca: authenticated_id: olivier@olivierlanglois.net X-Authenticated-Sender: cloud48395.mywhc.ca: olivier@olivierlanglois.net X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, 2021-08-07 at 07:51 -0600, Jens Axboe wrote: > > Please do - and please always run the full set of tests before > sending > out changes like this, you would have seen the slower runs and/or > timeouts from the regression suite. I ended up wasting time on this > thinking it was a change I made that broke it, before then debugging > this one. > Jens, for my personal info, where is the regression suite?