public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Christoph Hellwig <hch@infradead.org>,
	Joanne Koong <joannelkoong@gmail.com>
Cc: axboe@kernel.dk, io-uring@vger.kernel.org,
	csander@purestorage.com, krisman@suse.de, bernd@bsbernd.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed buffer rings
Date: Fri, 13 Feb 2026 15:48:11 +0000	[thread overview]
Message-ID: <a7d9d3ca-16b1-4299-a7fe-2fc19ca894cb@gmail.com> (raw)
In-Reply-To: <7c241b57-95d4-4d58-8cd3-369751f17df1@gmail.com>

On 2/13/26 15:31, Pavel Begunkov wrote:
> On 2/13/26 07:27, Christoph Hellwig wrote:
>> On Thu, Feb 12, 2026 at 09:29:31AM -0800, Joanne Koong wrote:
>>>>> I'm arguing exactly against this.  For my use case I need a setup
>>>>> where the kernel controls the allocation fully and guarantees user
>>>>> processes can only read the memory but never write to it.  I'd love
>>>
>>> By "control the allocation fully" do you mean for your use case, the
>>> allocation/setup isn't triggered by userspace but is initiated by the
>>> kernel (eg user never explicitly registers any kbuf ring, the kernel
>>> just uses the kbuf ring data structure internally and users can read
>>> the buffer contents)? If userspace initiates the setup of the kbuf
>>> ring, going through IORING_REGISTER_MEM_REGION would be semantically
>>> the same, except the buffer allocation by the kernel now happens
>>> before the ring is created and then later populated into the ring.
>>> userspace would still need to make an mmap call to the region and the
>>> kernel could enforce that as read-only. But if userspace doesn't
>>> initiate the setup, then going through IORING_REGISTER_MEM_REGION gets
>>> uglier.
>>
>> The idea is that the application tells the kernel that it wants to use
>> a fixed buffer pool for reads.  Right now the application does this
>> using io_uring_register_buffers().  The problem with that is that
>> io_uring_register_buffers ends up just doing a pin of the memory,
>> but the application or, in case of shared memory, someone else could
>> still modify the memory.  If the underlying file system or storage
>> device needs verify checksums, or worse rebuild data from parity
>> (or uncompress), it needs to ensure that the memory it is operating
>> on can't be modified by someone else.
>>
>> So I've been thinking of a version of io_uring_register_buffers where
>> the buffers are not provided by the application, but instead by the
>> kernel and mapped into the application address space read-only for
>> a while, and I thought I could implement this on top of your series,
>> but I have to admit I haven't really looked into the details all
>> that much.
> 
> There is nothing about registered buffers in this series. And even
> if you try to reuse buffer allocation out of it, it'll come with
> a circular buffer you'll have no need for. And I'm pretty much
> arguing about separating those for io_uring.

FWIW, the easiest solution is to internally reuse regions for
allocations and mmap()'ing and wrap it into a registered buffer.
It just need to make vmap'ing optional as it won't be needed.

-- 
Pavel Begunkov


  reply	other threads:[~2026-02-13 15:48 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  0:28 [PATCH v1 00/11] io_uring: add kernel-managed buffer rings Joanne Koong
2026-02-10  0:28 ` [PATCH v1 01/11] io_uring/kbuf: refactor io_register_pbuf_ring() logic into generic helpers Joanne Koong
2026-02-10  0:28 ` [PATCH v1 02/11] io_uring/kbuf: rename io_unregister_pbuf_ring() to io_unregister_buf_ring() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed buffer rings Joanne Koong
2026-02-10 16:34   ` Pavel Begunkov
2026-02-10 19:39     ` Joanne Koong
2026-02-11 12:01       ` Pavel Begunkov
2026-02-11 22:06         ` Joanne Koong
2026-02-12 10:07           ` Christoph Hellwig
2026-02-12 10:52             ` Pavel Begunkov
2026-02-12 17:29               ` Joanne Koong
2026-02-13  7:27                 ` Christoph Hellwig
2026-02-13 15:31                   ` Pavel Begunkov
2026-02-13 15:48                     ` Pavel Begunkov [this message]
2026-02-13 19:09                     ` Joanne Koong
2026-02-13 19:30                       ` Bernd Schubert
2026-02-13 19:38                         ` Joanne Koong
2026-02-13 19:14                   ` Joanne Koong
2026-02-13 16:27                 ` Pavel Begunkov
2026-02-13  7:21               ` Christoph Hellwig
2026-02-13 13:18                 ` Pavel Begunkov
2026-02-13 15:26           ` Pavel Begunkov
2026-02-11 15:45     ` Christoph Hellwig
2026-02-12 10:44       ` Pavel Begunkov
2026-02-13  7:18         ` Christoph Hellwig
2026-02-13 12:41           ` Pavel Begunkov
2026-02-13 22:04             ` Joanne Koong
2026-02-10  0:28 ` [PATCH v1 04/11] io_uring/kbuf: add mmap " Joanne Koong
2026-02-10  1:02   ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 05/11] io_uring/kbuf: support kernel-managed buffer rings in buffer selection Joanne Koong
2026-02-10  0:28 ` [PATCH v1 06/11] io_uring/kbuf: add buffer ring pinning/unpinning Joanne Koong
2026-02-10  1:07   ` Jens Axboe
2026-02-10 17:57     ` Caleb Sander Mateos
2026-02-10 18:00       ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 07/11] io_uring/kbuf: add recycling for kernel managed buffer rings Joanne Koong
2026-02-10  0:52   ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 08/11] io_uring/kbuf: add io_uring_is_kmbuf_ring() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 09/11] io_uring/kbuf: export io_ring_buffer_select() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 10/11] io_uring/kbuf: return buffer id in buffer selection Joanne Koong
2026-02-10  0:53   ` Jens Axboe
2026-02-10 22:36     ` Joanne Koong
2026-02-10  0:28 ` [PATCH v1 11/11] io_uring/cmd: set selected buffer index in __io_uring_cmd_done() Joanne Koong
2026-02-10  0:55 ` [PATCH v1 00/11] io_uring: add kernel-managed buffer rings Jens Axboe
2026-02-10 22:45   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7d9d3ca-16b1-4299-a7fe-2fc19ca894cb@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bernd@bsbernd.com \
    --cc=csander@purestorage.com \
    --cc=hch@infradead.org \
    --cc=io-uring@vger.kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=krisman@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox