From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B7C14535E; Tue, 12 Mar 2024 18:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710268688; cv=none; b=SOkFnTuMHnz82BJD3zIlelwbbXKmIUVVRn+XX4x/lk0q9GGh2pQqPOrQVoUesUbjeZEL3aT+mif6KjattlJhyurLEOkRnHQ0SqynStfPkXeD3XEIuSnkYrZm0aF76tjeQ0VeUq82sFk3UiamS7A+R09nIj5XURf1Vb/wgqCrZ+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710268688; c=relaxed/simple; bh=KBeNabMPyHZTzPFwHRuKA/oMBkMVrKwDeLe1Oa3s8AA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bgfzHNiVtbpQKd1Y5keIhOlr6SI6XIJEdWotQpW8YJC/fwsUTQ7D1/gdYsSXGqzfaJChUZahX+F19CV+hE/6Ge/nghVDJmQlpyaYdJhipS6qO3UWsM3Q+gOv0xJGJOOEAxI9IKbFd3CejGF8/SZTWRji8iq2gxuxl5mdpKLwnKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=SSss0uhJ; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="SSss0uhJ" Received: from localhost (unknown [10.10.165.10]) by mail.ispras.ru (Postfix) with ESMTPSA id 7F4AF40AC4FF; Tue, 12 Mar 2024 18:38:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 7F4AF40AC4FF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1710268682; bh=L9dzc+wGc4r7hud1ML6f1cQ5Otk2+AYhLY1+PNPRrw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSss0uhJu0QRrKAmX2o8P4uMjMC7LUrMbVuiWtXTum3vdp5J/D8y+s/nCVNJp1lZu 6lAaNOqkjRptT6ID+BJ/AJRE07D0DYW3JXv10cZxt30Z+qlsregCeFSToYnqbmMEh3 AxwNoxPWgp5ixLhYCrP8lF3Fgms59WvPHmdY3I8U= Date: Tue, 12 Mar 2024 21:38:02 +0300 From: Fedor Pchelkin To: Jens Axboe Cc: Pavel Begunkov , Greg Kroah-Hartman , stable@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, Nikita Zhandarovich , Roman Belyaev Subject: Re: [PATCH 5.10/5.15] io_uring: fix registered files leak Message-ID: References: <20240312142313.3436-1-pchelkin@ispras.ru> <8a9993c7-fd4d-44ff-8971-af59c7f3052c@kernel.dk> <466e842f-66c6-4530-8c16-2b008fc3fbc6-pchelkin@ispras.ru> <085beb85-d1a4-4cb0-969b-e0f895a95738@kernel.dk> Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <085beb85-d1a4-4cb0-969b-e0f895a95738@kernel.dk> On 24/03/12 11:54AM, Jens Axboe wrote: > On 3/12/24 9:21 AM, Jens Axboe wrote: > > On 3/12/24 9:14 AM, Fedor Pchelkin wrote: > >> On 24/03/12 08:34AM, Jens Axboe wrote: > >>> On 3/12/24 8:23 AM, Fedor Pchelkin wrote: > >> > >> [...] > >> > >>>> I feel io_uring-SCM related code should be dropped entirely from the > >>>> stable branches as the backports already differ greatly between versions > >>>> and some parts are still kept, some have been dropped in a non-consistent > >>>> order. Though this might contradict with stable kernel rules or be > >>>> inappropriate for some other reason. > >>> > >>> Looks fine to me, and I agree, it makes much more sense to drop it all > >>> from 5.10/5.15-stable as well to keep them in sync with upstream. And I > >>> think this is fine for stable, dropping code is always a good thing. > >>> > >> > >> Alright, got it. So that would require dropping it from all of the > >> supported 5.4, 6.1, 6.6, 6.7, too. > >> > >> Would it be okay if I'll send this as a series? > > > > Yeah I think so, keeping the code more in sync is always a good thing > > when it comes to stable. Just make sure you mark the backport commits > > with the appropriate upstream shas. Thanks! > > I'll just do these backports myself, thanks for bringing it up. Great, thanks! -- Fedor