From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31852C11CA for ; Tue, 6 Jan 2026 19:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767729079; cv=none; b=EkLpxb2wZRIxVu9CcBzn/6hXp6/ceOBERj0Be/HJE4PQiiChnF3PpmzbCHc/8tuJbjvoL8Xv9QoB7fhkIESE2guAtjSK1g7Nj8YMmf8SLz4q2dfr30jXFXUsjGqVdyKSpZB4z9z4pua+pAFPhlrHrRlJ9U4QiFjCOmA2sbGhxzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767729079; c=relaxed/simple; bh=lHxyhw/2ECuTZwsuxRhqHF7q0GnOP8IQA1gLR0EAaao=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pmpeE2l91d3Tq5AtQSpjAyLVgg23FoGWadTJMHAXfRHH4CcRp4FMfavr9re2cDRg2s20WXuMjlIDgmjUatXrrl5yHFySgvvF4mBkgNO0Y6B9Du8iyvymvGyeTjqOAUX8DGyXHBef7rx87NJn7oavIgKc+iuEM1+23Of/HyuNCNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GEK7fZu2; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GEK7fZu2" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-42fbc544b09so877507f8f.1 for ; Tue, 06 Jan 2026 11:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767729076; x=1768333876; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ovZgk8PxCrhilP9ak1FB2YkidalwKuZZczfXtCx59dw=; b=GEK7fZu22juEKoMqHTh/UIQCo4vg9eUE/aRaG+aroaUaGX1Hv5Cti0Y8ZBvTn83WIQ Ls+PanyNnhvdqk4FkLhAPaSlTOMwHvQz0BAyeT46JdzUNDy6AbV6rTyI/gF9J9ltRxQ5 qQKtY3ADsKUoiiqQuAc6iLAaXHHQj3APDu8qfY6CGTwfxULvFgzUt0Yx6iWD2Tv+wqgC 0iUtJpjmjpcH+67hgqPw65J/VOliFYZs/vyoD43mZ6bjoPWMORsVyYRgj5Nn+oeG3FUP GSN1QGMlv/7TY0n7L1xX9WelJRxvHniTArdGNPMX0jolb1OSs70TS64tYQr0nq7zMfY1 ugBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767729076; x=1768333876; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ovZgk8PxCrhilP9ak1FB2YkidalwKuZZczfXtCx59dw=; b=vd8MmqIECQfYXXvhBvARHHn4syV7L7dyEMKLhMKWrcfP3obBtcXV/3r5AWEKapcIs5 C0h9a6G9YqqCBrQHv2+FJ8zS36hEujI0xtxOYRX/8kehtHUAaN1ZtaybBdokO700LbI8 Xg7lN8iF6WDbwfmigMggX6fynunQb4B4ieulGyr6Oq8C3f33QCao4qZVqzAIh4+HzxHw QQW5WnXW0u0RuGJtCmwgjZb/TG3/gLq4ELj2mxS3Mpbbf7+FtMEARBD65Z1ZalOgrA09 osh8KyAEeATeTb+4a9yAOwhKOn0i37MgEiGPTC44U2rxg15T08JmSxSR5dpJLKx6fcpJ QjQQ== X-Forwarded-Encrypted: i=1; AJvYcCUZpLayNcBv+To6HHhyzQAPqCVsgk7JQCBGOuXjeXjec97C7Xy3fzFWTYa07V8aoKkIzrU2g/Br7w==@vger.kernel.org X-Gm-Message-State: AOJu0Yxyi+LdBhfgX/CW6KKSv2evsjvCigkZM6RF1c8aG1C5o2PBX3Qe BNA8Q6dAvHNyu5PGC8mBrkZNpF8jNbpC1YMiFfcaEBMZ1YnWIz/xtWtQ X-Gm-Gg: AY/fxX7myHBFA0c7QXkxjc+PC73Ajak0H2urgB45xN9OPvL6tk9e8KjaQsjppZP8SK0 ePlV7+Ln2Sn9L0s72G7RP8IxR249X4s4TAo0tmh7cvOmRbdmde5NMK5/ojMsLUnaStdkP8/BPgz MhVLSrOaid0K07emRRvq8DAEQyMiCt7PMbvxeCb37CuYDAo5TUBKox8uNJiah5tvjMihMHYereJ e68j4O1RuJJxi7Q1VyoZEc+vB3oxjQ3RY9MdgPw6soNsVVKkrXg7Pg/g4jf4uh/i9rfdw02DPuK fqI2GVYcTgu8gCiizadGRHLh5xu3Q7YgauFBPWwbIHT189jdgp3H8TZIxHZXQxjOF3r1xkJSHde ET7KxFi3FX9NuXuwaxhSznfkDQsEh4ixaq7U9Xam55KYBOvKAKK2ngXrYpWT3tXM5d8nwEjfhrK D+5jwUEwJnmPKmyHiPLJTOJbbCq+hn4ULuZEmGUdWYyHt7XbaDVNHSSBhy9LiGh6Rez1toJNWLr u7FwwlM7roG5PXyQOV8guwZjrFcNBBXIiwTY+v9tlC2Xbm9JCVBWhRK709AnEHB X-Google-Smtp-Source: AGHT+IFFym+HTWb6WhRU4bKfzHds67XbzvjVQ0ncM7+fS6yOVWLogcdaslK7a3BF15xU4e7GXQY5lg== X-Received: by 2002:a5d:5f51:0:b0:430:fdb8:8510 with SMTP id ffacd0b85a97d-432c3790ca4mr333772f8f.24.1767729076041; Tue, 06 Jan 2026 11:51:16 -0800 (PST) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e19bfsm6241105f8f.18.2026.01.06.11.51.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 11:51:15 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 19:51:12 +0000 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 01/11] file: add callback for pre-mapping dmabuf To: Ming Lei , Christoph Hellwig Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-block@vger.kernel.org, io-uring@vger.kernel.org, Vishal Verma , tushar.gohad@intel.com, Keith Busch , Jens Axboe , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org References: <74d689540fa200fe37f1a930165357a92fe9e68c.1763725387.git.asml.silence@gmail.com> <7b2017f4-02a3-482a-a173-bb16b895c0cb@amd.com> <20251204110709.GA22971@lst.de> <0571ca61-7b17-4167-83eb-4269bd0459fe@amd.com> <20251204131025.GA26860@lst.de> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/4/26 01:42, Ming Lei wrote: > On Thu, Dec 04, 2025 at 02:10:25PM +0100, Christoph Hellwig wrote: >> On Thu, Dec 04, 2025 at 12:09:46PM +0100, Christian König wrote: >>>> I find the naming pretty confusing a well. But what this does is to >>>> tell the file system/driver that it should expect a future >>>> read_iter/write_iter operation that takes data from / puts data into >>>> the dmabuf passed to this operation. >>> >>> That explanation makes much more sense. >>> >>> The remaining question is why does the underlying file system / driver >>> needs to know that it will get addresses from a DMA-buf? >> >> This eventually ends up calling dma_buf_dynamic_attach and provides >> a way to find the dma_buf_attachment later in the I/O path. > > Maybe it can be named as ->dma_buf_attach()? For wiring dma-buf and the > importer side(nvme). > > But I am wondering why not make it as one subsystem interface, such as nvme > ioctl, then the whole implementation can be simplified a lot. It is reasonable > because subsystem is exactly the side for consuming/importing the dma-buf. It's not an nvme specific interface, and so a file op was much more convenient. And ioctls for registering it into io_uring would also be problematic. I simplified some of the layering for the next version, but most of the complexity comes from handling in blk-mq-dma-token.h, it'd be same even if made nvme specific. In fact, I had it all first in nvme but then had to move to block/ because of sleeping. -- Pavel Begunkov