From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F07C433EF for ; Thu, 23 Sep 2021 14:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C744E61090 for ; Thu, 23 Sep 2021 14:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241604AbhIWOH3 (ORCPT ); Thu, 23 Sep 2021 10:07:29 -0400 Received: from cloud48395.mywhc.ca ([173.209.37.211]:50538 "EHLO cloud48395.mywhc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241554AbhIWOH1 (ORCPT ); Thu, 23 Sep 2021 10:07:27 -0400 Received: from modemcable064.203-130-66.mc.videotron.ca ([66.130.203.64]:53332 helo=[192.168.1.179]) by cloud48395.mywhc.ca with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mTPMG-0000Sp-Gb; Thu, 23 Sep 2021 10:05:52 -0400 Message-ID: Subject: Re: [5.15-rc1 regression] io_uring: fsstress hangs in do_coredump() on exit From: Olivier Langlois To: Jens Axboe , Dave Chinner Cc: io-uring , linux-fsdevel Date: Thu, 23 Sep 2021 10:05:51 -0400 In-Reply-To: <6d46951b-a7b3-0feb-3af0-aaa8ec87b87a@kernel.dk> References: <20210921064032.GW2361455@dread.disaster.area> <20210921213552.GZ2361455@dread.disaster.area> <6d46951b-a7b3-0feb-3af0-aaa8ec87b87a@kernel.dk> Organization: Trillion01 Inc Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud48395.mywhc.ca X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - trillion01.com X-Get-Message-Sender-Via: cloud48395.mywhc.ca: authenticated_id: olivier@trillion01.com X-Authenticated-Sender: cloud48395.mywhc.ca: olivier@trillion01.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, 2021-09-21 at 15:41 -0600, Jens Axboe wrote: > > > > Cleaned up so it compiles and the tests run properly again. But > > playing whack-a-mole with signals seems kinda fragile. I was > > pointed > > to this patchset by another dev on #xfs overnight who saw the same > > hangs that also fixed the hang: > > It seems sane to me - exit if there's a fatal signal, or doing core > dump. Don't think there should be other conditions. > > > https://lore.kernel.org/lkml/cover.1629655338.git.olivier@trillion0 > > 1.com/ > > > > It was posted about a month ago and I don't see any response to it > > on the lists... > > That's been a long discussion, but it's a different topic really. Yes > it's signals, but it's not this particular issue. It'll happen to > work > around this issue, as it cancels everything post core dumping. > I am glad to see that my patch is still on your radar. I was starting to wonder if it did somehow slip in a floor crack or if I did omit to do something justifying that noone is reviewing it. I guess that everyone has been crazy busy like mad men in the last few weeks...