From: Keith Busch <kbusch@kernel.org>
To: Nitesh Shetty <nitheshshetty@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
gost.dev@samsung.com, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring/rsrc: send exact nr_segs for fixed buffer
Date: Wed, 16 Apr 2025 14:03:25 -0600 [thread overview]
Message-ID: <aAANDZUvjPckRik4@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAOSviJ3MNDOYJzJFjQDCjc04pGsktQ5vjQvDotqYoRwC2Wf=HQ@mail.gmail.com>
On Thu, Apr 17, 2025 at 01:27:55AM +0530, Nitesh Shetty wrote:
> > + /*
> > + * Offset trimmed front segments too, if any, now trim the tail.
> > + * For is_kbuf we'll iterate them as they may be different sizes,
> > + * otherwise we can just do straight up math.
> > + */
> > + if (len + offset < imu->len) {
> > + bvec = iter->bvec;
> > + if (imu->is_kbuf) {
> > + while (len > bvec->bv_len) {
> > + len -= bvec->bv_len;
> > + bvec++;
> > + }
> > + iter->nr_segs = bvec - iter->bvec;
> > + } else {
> > + size_t vec_len;
> > +
> > + vec_len = bvec->bv_offset + iter->iov_offset +
> > + iter->count + ((1UL << folio_shift) - 1);
> > + iter->nr_segs = vec_len >> folio_shift;
> > + }
> > + }
> > return 0;
> > }
> This might not be needed for is_kbuf , as they already update nr_seg
> inside iov_iter_advance.
iov_iter_advance only handles the front segs. We still need something
for any trailing segments that are not part of this mapping request.
prev parent reply other threads:[~2025-04-16 20:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250416055250epcas5p25fa8223a1bfeea5583ad8ba88c881a05@epcas5p2.samsung.com>
2025-04-16 5:44 ` [PATCH] io_uring/rsrc: send exact nr_segs for fixed buffer Nitesh Shetty
2025-04-16 14:19 ` Jens Axboe
2025-04-16 14:43 ` Jens Axboe
2025-04-16 14:49 ` Jens Axboe
2025-04-16 15:03 ` Pavel Begunkov
2025-04-16 15:07 ` Jens Axboe
2025-04-16 18:25 ` Jens Axboe
2025-04-16 19:57 ` Nitesh Shetty
2025-04-16 20:01 ` Jens Axboe
2025-04-16 20:29 ` Pavel Begunkov
2025-04-16 20:30 ` Jens Axboe
2025-04-16 21:03 ` Pavel Begunkov
2025-04-16 22:23 ` Jens Axboe
2025-04-16 22:42 ` Jens Axboe
2025-04-17 9:12 ` Pavel Begunkov
2025-04-16 20:03 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAANDZUvjPckRik4@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitheshshetty@gmail.com \
--cc=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox