public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] io_uring: update parameter name in io_pin_pages function declaration
@ 2025-04-19  6:47 Long Li
  0 siblings, 0 replies; 4+ messages in thread
From: Long Li @ 2025-04-19  6:47 UTC (permalink / raw)
  To: axboe, asml.silence
  Cc: io-uring, linux-kernel, yi.zhang, leo.lilong, yangerkun,
	lonuxli.64

Fix inconsistent first parameter name in io_pin_pages between declaration
and implementation. Renamed `ubuf` to `uaddr` for better clarity.

Fixes: 1943f96b3816 ("io_uring: unify io_pin_pages()")
Signed-off-by: Long Li <leo.lilong@huawei.com>
---
 io_uring/memmap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/memmap.h b/io_uring/memmap.h
index dad0aa5b1b45..b9415a766c26 100644
--- a/io_uring/memmap.h
+++ b/io_uring/memmap.h
@@ -4,7 +4,7 @@
 #define IORING_MAP_OFF_PARAM_REGION		0x20000000ULL
 #define IORING_MAP_OFF_ZCRX_REGION		0x30000000ULL
 
-struct page **io_pin_pages(unsigned long ubuf, unsigned long len, int *npages);
+struct page **io_pin_pages(unsigned long uaddr, unsigned long len, int *npages);
 
 #ifndef CONFIG_MMU
 unsigned int io_uring_nommu_mmap_capabilities(struct file *file);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] io_uring: update parameter name in io_pin_pages function declaration
@ 2025-04-25 11:32 leo.lilong
  2025-04-25 11:47 ` Pavel Begunkov
  0 siblings, 1 reply; 4+ messages in thread
From: leo.lilong @ 2025-04-25 11:32 UTC (permalink / raw)
  To: axboe, asml.silence; +Cc: leo.lilong, yangerkun, io-uring

From: Long Li <leo.lilong@huawei.com>

Fix inconsistent first parameter name in io_pin_pages between declaration
and implementation. Renamed `ubuf` to `uaddr` for better clarity.

Fixes: 1943f96b3816 ("io_uring: unify io_pin_pages()")
Signed-off-by: Long Li <leo.lilong@huawei.com>
---
 io_uring/memmap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/memmap.h b/io_uring/memmap.h
index dad0aa5b1b45..b9415a766c26 100644
--- a/io_uring/memmap.h
+++ b/io_uring/memmap.h
@@ -4,7 +4,7 @@
 #define IORING_MAP_OFF_PARAM_REGION		0x20000000ULL
 #define IORING_MAP_OFF_ZCRX_REGION		0x30000000ULL
 
-struct page **io_pin_pages(unsigned long ubuf, unsigned long len, int *npages);
+struct page **io_pin_pages(unsigned long uaddr, unsigned long len, int *npages);
 
 #ifndef CONFIG_MMU
 unsigned int io_uring_nommu_mmap_capabilities(struct file *file);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: update parameter name in io_pin_pages function declaration
  2025-04-25 11:32 [PATCH] io_uring: update parameter name in io_pin_pages function declaration leo.lilong
@ 2025-04-25 11:47 ` Pavel Begunkov
  2025-05-08  6:26   ` Long Li
  0 siblings, 1 reply; 4+ messages in thread
From: Pavel Begunkov @ 2025-04-25 11:47 UTC (permalink / raw)
  To: leo.lilong, axboe; +Cc: leo.lilong, yangerkun, io-uring

On 4/25/25 12:32, leo.lilong@huaweicloud.com wrote:
> From: Long Li <leo.lilong@huawei.com>
> 
> Fix inconsistent first parameter name in io_pin_pages between declaration
> and implementation. Renamed `ubuf` to `uaddr` for better clarity.
> 
> Fixes: 1943f96b3816 ("io_uring: unify io_pin_pages()")

I'm split on whether such patches make sense, slightly leaning
that they don't, but regardless, why is it a fix and which
problem exactly does it "fix"?

> Signed-off-by: Long Li <leo.lilong@huawei.com>
> ---
>   io_uring/memmap.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/io_uring/memmap.h b/io_uring/memmap.h
> index dad0aa5b1b45..b9415a766c26 100644
> --- a/io_uring/memmap.h
> +++ b/io_uring/memmap.h
> @@ -4,7 +4,7 @@
>   #define IORING_MAP_OFF_PARAM_REGION		0x20000000ULL
>   #define IORING_MAP_OFF_ZCRX_REGION		0x30000000ULL
>   
> -struct page **io_pin_pages(unsigned long ubuf, unsigned long len, int *npages);
> +struct page **io_pin_pages(unsigned long uaddr, unsigned long len, int *npages);
>   
>   #ifndef CONFIG_MMU
>   unsigned int io_uring_nommu_mmap_capabilities(struct file *file);

-- 
Pavel Begunkov


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: update parameter name in io_pin_pages function declaration
  2025-04-25 11:47 ` Pavel Begunkov
@ 2025-05-08  6:26   ` Long Li
  0 siblings, 0 replies; 4+ messages in thread
From: Long Li @ 2025-05-08  6:26 UTC (permalink / raw)
  To: Pavel Begunkov, leo.lilong, axboe; +Cc: yangerkun, io-uring

On Fri, Apr 25, 2025 at 12:47:00PM +0100, Pavel Begunkov wrote:
> On 4/25/25 12:32, leo.lilong@huaweicloud.com wrote:
> > From: Long Li <leo.lilong@huawei.com>
> > 
> > Fix inconsistent first parameter name in io_pin_pages between declaration
> > and implementation. Renamed `ubuf` to `uaddr` for better clarity.
> > 
> > Fixes: 1943f96b3816 ("io_uring: unify io_pin_pages()")
> 
> I'm split on whether such patches make sense, slightly leaning
> that they don't, but regardless, why is it a fix and which
> problem exactly does it "fix"?
> 

You're right - this is not actually a "fix" as it only changes a parameter
name for consistency and clarity. I'll resend the patch without the fix tag.

Thanks,
Long Li

> > Signed-off-by: Long Li <leo.lilong@huawei.com>
> > ---
> >   io_uring/memmap.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/io_uring/memmap.h b/io_uring/memmap.h
> > index dad0aa5b1b45..b9415a766c26 100644
> > --- a/io_uring/memmap.h
> > +++ b/io_uring/memmap.h
> > @@ -4,7 +4,7 @@
> >   #define IORING_MAP_OFF_PARAM_REGION		0x20000000ULL
> >   #define IORING_MAP_OFF_ZCRX_REGION		0x30000000ULL
> > -struct page **io_pin_pages(unsigned long ubuf, unsigned long len, int *npages);
> > +struct page **io_pin_pages(unsigned long uaddr, unsigned long len, int *npages);
> >   #ifndef CONFIG_MMU
> >   unsigned int io_uring_nommu_mmap_capabilities(struct file *file);
> 
> -- 
> Pavel Begunkov
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-08  6:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-25 11:32 [PATCH] io_uring: update parameter name in io_pin_pages function declaration leo.lilong
2025-04-25 11:47 ` Pavel Begunkov
2025-05-08  6:26   ` Long Li
  -- strict thread matches above, loose matches on Subject: below --
2025-04-19  6:47 Long Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox