From: Keith Busch <kbusch@kernel.org>
To: Penglei Jiang <superman.xpt@gmail.com>
Cc: axboe@kernel.dk, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+531502bbbe51d2f769f4@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] io_uring: fix use-after-free of sq->thread in __io_uring_show_fdinfo()
Date: Tue, 10 Jun 2025 12:44:31 -0600 [thread overview]
Message-ID: <aEh9DxZ0AQSSranB@kbusch-mbp> (raw)
In-Reply-To: <20250610171801.70960-1-superman.xpt@gmail.com>
On Tue, Jun 10, 2025 at 10:18:01AM -0700, Penglei Jiang wrote:
> @@ -379,7 +380,8 @@ static int io_sq_thread(void *data)
> io_sq_tw(&retry_list, UINT_MAX);
>
> io_uring_cancel_generic(true, sqd);
> - sqd->thread = NULL;
> + rcu_assign_pointer(sqd->thread, NULL);
I believe this will fail a sparse check without adding the "__rcu" type
annotation on the struct's "thread" member.
next prev parent reply other threads:[~2025-06-10 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 17:18 [PATCH v2] io_uring: fix use-after-free of sq->thread in __io_uring_show_fdinfo() Penglei Jiang
2025-06-10 17:23 ` Jens Axboe
2025-06-10 18:44 ` Keith Busch [this message]
2025-06-10 18:56 ` Jens Axboe
2025-06-10 19:12 ` Keith Busch
2025-06-10 19:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEh9DxZ0AQSSranB@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=superman.xpt@gmail.com \
--cc=syzbot+531502bbbe51d2f769f4@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox