From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Qingyue Zhang <chunzhennn@qq.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
Suoxing Zhang <aftern00n@qq.com>
Subject: Re: [PATCH 2/2] io_uring/kbuf: fix infinite loop in io_kbuf_inc_commit()
Date: Wed, 27 Aug 2025 15:59:23 -0600 [thread overview]
Message-ID: <aK9_u9ZK9NgKiBkE@kbusch-mbp> (raw)
In-Reply-To: <4b8eb795-239f-4f46-af4f-7a05056ab516@kernel.dk>
On Wed, Aug 27, 2025 at 03:45:28PM -0600, Jens Axboe wrote:
> > + buf_len = READ_ONCE(buf->len);
> > + this_len = min_t(int, len, buf_len);
> > + buf_len -= this_len;
> > + if (buf_len) {
> > buf->addr += this_len;
> > + buf->len = buf_len;
> > return false;
> > }
> > + buf->len = 0;
Purely for symmetry, assigning buf->len ought to be a WRITE_ONCE.
next prev parent reply other threads:[~2025-08-27 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250827114339.367080-1-chunzhennn@qq.com>
2025-08-27 11:44 ` [PATCH 2/2] io_uring/kbuf: fix infinite loop in io_kbuf_inc_commit() Qingyue Zhang
2025-08-27 14:30 ` Jens Axboe
2025-08-27 21:45 ` Jens Axboe
2025-08-27 21:59 ` Keith Busch [this message]
2025-08-27 22:23 ` Jens Axboe
2025-08-28 1:36 ` Qingyue Zhang
2025-08-28 2:08 ` Jens Axboe
2025-08-28 2:49 ` Qingyue Zhang
2025-08-28 2:50 ` Jens Axboe
2025-08-28 2:58 ` Jens Axboe
2025-08-28 3:27 ` Qingyue Zhang
2025-08-28 11:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aK9_u9ZK9NgKiBkE@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=aftern00n@qq.com \
--cc=axboe@kernel.dk \
--cc=chunzhennn@qq.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox