From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Keith Busch <kbusch@meta.com>, axboe@kernel.dk, io-uring@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] io_uring: add support for IORING_SETUP_SQE_MIXED
Date: Tue, 2 Sep 2025 12:03:19 -0600 [thread overview]
Message-ID: <aLcxZ1mfG2pGDscF@kbusch-mbp> (raw)
In-Reply-To: <CADUfDZqpTsEOROA0Tkrq1WprpBvmzvhMPiFXZwLT4WMTSmAXqQ@mail.gmail.com>
On Fri, Aug 29, 2025 at 02:29:39PM -0700, Caleb Sander Mateos wrote:
>
> There are a few other users of IORING_SETUP_SQE128 that likely need to
> be made aware of IOSQE_SQE_128B. For one, uring_sqe_size(), which is
> used to determine how large the SQE payload is when copying it for a
> uring_cmd that goes async. And the logic for setting IO_URING_F_SQE128
> in io_uring_cmd() also needs to be adjusted.
Yeah, you're right. I did the liburing side first, and was a bit excited
to see the nop test was working correctly so quickly that I didn't
finish all the pieces. I'll get all that worked out on the next version.
Thanks for the comments!
next prev parent reply other threads:[~2025-09-02 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 19:39 [RFC PATCH 0/1] io_uring: mixed sqe support Keith Busch
2025-08-29 19:39 ` [RFC PATCH liburing 1/2] Add support IORING_SETUP_SQE_MIXED Keith Busch
2025-08-29 19:39 ` [RFC PATCH 1/1] io_uring: add support for IORING_SETUP_SQE_MIXED Keith Busch
2025-08-29 21:29 ` Caleb Sander Mateos
2025-09-02 18:03 ` Keith Busch [this message]
2025-08-29 19:39 ` [RFC PATCH liburing 2/2] Add nop testing " Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLcxZ1mfG2pGDscF@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox