From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, io-uring@vger.kernel.org,
Caleb Sander Mateos <csander@purestorage.com>,
huang-jl <huang-jl@deepseek.com>,
Nitesh Shetty <nj.shetty@samsung.com>
Subject: Re: [PATCH 1/3] block: fix bio_may_need_split() by using bvec iterator way
Date: Thu, 18 Dec 2025 01:37:37 -0800 [thread overview]
Message-ID: <aUPLYcAx2dh-DvuP@infradead.org> (raw)
In-Reply-To: <20251218093146.1218279-2-ming.lei@redhat.com>
On Thu, Dec 18, 2025 at 05:31:42PM +0800, Ming Lei wrote:
> ->bi_vcnt doesn't make sense for cloned bio, which is perfectly fine
> passed to bio_may_need_split().
>
> So fix bio_may_need_split() by not taking ->bi_vcnt directly, instead
> checking with help from bio size and bvec->len.
>
> Meantime retrieving the 1st bvec via __bvec_iter_bvec().
That totally misses the point. The ->bi_vcnt is a fast and lose
check to see if we need the fairly expensive iterators to do the
real check.
next prev parent reply other threads:[~2025-12-18 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 9:31 [PATCH 0/3] block: fix bi_vcnt misuse for cloned bio Ming Lei
2025-12-18 9:31 ` [PATCH 1/3] block: fix bio_may_need_split() by using bvec iterator way Ming Lei
2025-12-18 9:37 ` Christoph Hellwig [this message]
2025-12-18 9:45 ` Ming Lei
2025-12-18 15:16 ` Nitesh Shetty
2025-12-18 16:08 ` Ming Lei
2025-12-20 8:16 ` Nitesh Shetty
2025-12-20 8:19 ` Nitesh Shetty
2025-12-18 9:31 ` [PATCH 2/3] block: don't initialize bi_vcnt for cloned bio in bio_iov_bvec_set() Ming Lei
2025-12-18 9:38 ` Christoph Hellwig
2025-12-18 9:48 ` Ming Lei
2025-12-18 9:31 ` [PATCH 3/3] io_uring: don't re-calculate iov_iter nr_segs in io_import_kbuf() Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUPLYcAx2dh-DvuP@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=huang-jl@deepseek.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox