From: Jens Axboe <[email protected]>
To: Kanchan Joshi <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] io_uring: cleanup error-handling around io_req_complete
Date: Sun, 24 Apr 2022 18:32:27 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20220424062241.GA17917@test-zns>
On 4/24/22 12:22 AM, Kanchan Joshi wrote:
> On Sat, Apr 23, 2022 at 12:06:05PM -0600, Jens Axboe wrote:
>> On 4/22/22 4:10 AM, Kanchan Joshi wrote:
>>> Move common error-handling to io_req_complete, so that various callers
>>> avoid repeating that. Few callers (io_tee, io_splice) require slightly
>>> different handling. These are changed to use __io_req_complete instead.
>>
>> This seems incomplete, missing msgring and openat2 at least? I do like
>> the change though. Care to respin a v2?
>
> But both (io_msg_ring, and io_openat2) are already using
> __io_req_complete (and not io_req_complete). So nothing is amiss?
Yeah, I guess it's actually fine like that, and would in any case
require more changes to unify the rest. So let's just go with this for
now.
--
Jens Axboe
next prev parent reply other threads:[~2022-04-25 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220422101608epcas5p22e9c82eb1b3beef6bf6e1c2e83b4b19b@epcas5p2.samsung.com>
2022-04-22 10:10 ` [PATCH] io_uring: cleanup error-handling around io_req_complete Kanchan Joshi
2022-04-23 17:49 ` Christoph Hellwig
2022-04-23 18:06 ` Jens Axboe
2022-04-24 6:22 ` Kanchan Joshi
2022-04-25 0:32 ` Jens Axboe [this message]
2022-04-25 0:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox