From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,TRACKER_ID,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B11FC433DF for ; Thu, 13 Aug 2020 22:31:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0304F20838 for ; Thu, 13 Aug 2020 22:31:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="AGEicqwW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgHMWbv (ORCPT ); Thu, 13 Aug 2020 18:31:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726568AbgHMWbv (ORCPT ); Thu, 13 Aug 2020 18:31:51 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6877EC061757 for ; Thu, 13 Aug 2020 15:31:51 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id y206so3544411pfb.10 for ; Thu, 13 Aug 2020 15:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HL0boH9f/6g4x59TkaSVU8AHlDUPYgL8whmbto2/a6M=; b=AGEicqwWHDzDFEnRrthDh6sZOgA38z8TU47/zN/1zlasFrxp96VRgEy4IDxPiD6wkr e/kiz13yOd2YR9WHBfH9Zn5wY8Ieo1GLGfZrrZzkgjsuBROclI83EdPJngU1F3Xr5ypX EWniQUptpN4XVdk8cfouKvH5gU+FCARO4wiNguHWsEr9I3iwcrbOkGZL+lJ7hMEt7wxe EqpamTMQ5xlVl0ywX3S8JNPsPj3iXfLosZBcEHN1JIUNShstL/USUhpi3QqZmXCgkRpj wHtRtGAs9UXvkrBW7EHawtzkbqIc9Vcd3Iw4x1YenGhYUoV62y7tbt9P/7Pgxp0aKwoR DA6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HL0boH9f/6g4x59TkaSVU8AHlDUPYgL8whmbto2/a6M=; b=i5pRJ7edoTKNcwc2lKJT/5AteklKpA5aK7Om6gZENfQiXBbtWFdp7QpP7pOF5Si1Wb Xrf7Vv63hWmHQl22YmiFPYPD3oO0eWpvyPaDY+4Jzzj7SPEdjxokTJLWN2Ig8k1j+gny 71YVIcpRUT0GqVFtZUsum6Xq3bjrR98eVqkSjWktyEt0aJ/BXizFkY+tUac7fNEfpIPd 51pBfTX3UEjoe7+wlkO+VptTByfbg4j+0h+qbT/iY+PAhIZ0ccq1xhRltJpWq2IA+s2P mdaG3JGpWcR8pSjx9gBnsN9TIpMV070udFvyn22LvYeMdcud5iizhZfKnci7wc66TR28 N6QA== X-Gm-Message-State: AOAM532qL+PjocrkLiC6gGLwyuA9yo6tsNk65HVDutxObSHX1pDgk48m zkiXPe1MDSzjOBSSKwDGoHct6XW1dC0= X-Google-Smtp-Source: ABdhPJxLuZDWn1imAHh1ofppvgCbgDWaviQugBvvjW+LLZIiy0ZXoHXuYUJ3Ur8Pg0/+qqXnIgDhxQ== X-Received: by 2002:a63:2584:: with SMTP id l126mr5371146pgl.126.1597357910700; Thu, 13 Aug 2020 15:31:50 -0700 (PDT) Received: from ?IPv6:2600:380:7450:f4f3:ef44:fab:2a3e:c12d? ([2600:380:7450:f4f3:ef44:fab:2a3e:c12d]) by smtp.gmail.com with ESMTPSA id 27sm6251481pgk.89.2020.08.13.15.31.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2020 15:31:50 -0700 (PDT) Subject: Re: [PATCHSET 0/2] io_uring: handle short reads internally To: Jeff Moyer Cc: io-uring@vger.kernel.org, david@fromorbit.com References: <20200813175605.993571-1-axboe@kernel.dk> <99c39782-6523-ae04-3d48-230f40bc5d05@kernel.dk> <9f050b83-a64a-c112-fc26-309342076c71@kernel.dk> From: Jens Axboe Message-ID: Date: Thu, 13 Aug 2020 16:31:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 8/13/20 4:21 PM, Jeff Moyer wrote: > Jens Axboe writes: > >>>>> BTW, what git sha did you run? >>>> >>>> I do see a failure with dm on that, I'll take a look. >>> >>> I ran it on a file system atop nvme with 8 poll queues. >>> >>> liburing head: 9e1d69e078ee51f253a829ff421b17cfc996d158 >>> linux-block head: ff1353802d86a9d8e40ef1377efb12a1d3000a20 >> >> Fixed it, and actually enabled a further cleanup. > > Great, thanks! Did you push that out somewhere? It's pushed to io_uring-5.9, current sha is: ee6ac2d3d5cc50d58ca55a5967671c9c1f38b085 FWIW, the issue was just for fixed buffers. It's running through the usual testing now. -- Jens Axboe