From: Xiaoguang Wang <[email protected]>
To: Jens Axboe <[email protected]>, io-uring <[email protected]>
Subject: Re: regression: fixed file hang
Date: Thu, 14 May 2020 13:33:32 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
hi,
> On 5/13/20 12:45 PM, Jens Axboe wrote:
>> Hi Xiaoguang,
>>
>> Was doing some other testing today, and noticed a hang with fixed files.
>> I did a bit of poor mans bisecting, and came up with this one:
>>
>> commit 0558955373023b08f638c9ede36741b0e4200f58
>> Author: Xiaoguang Wang <[email protected]>
>> Date: Tue Mar 31 14:05:18 2020 +0800
>>
>> io_uring: refactor file register/unregister/update handling
>>
>> If I revert this one, the test completes fine.
>>
>> The case case is pretty simple, just run t/io_uring from the fio
>> repo, default settings:
>>
>> [ fio] # t/io_uring /dev/nvme0n1p2
>> Added file /dev/nvme0n1p2
>> sq_ring ptr = 0x0x7fe1cb81f000
>> sqes ptr = 0x0x7fe1cb81d000
>> cq_ring ptr = 0x0x7fe1cb81b000
>> polled=1, fixedbufs=1, buffered=0 QD=128, sq_ring=128, cq_ring=256
>> submitter=345
>> IOPS=240096, IOS/call=32/31, inflight=91 (91)
>> IOPS=249696, IOS/call=32/31, inflight=99 (99)
>> ^CExiting on signal 2
>>
>> and ctrl-c it after a second or so. You'll then notice a kworker that
>> is stuck in io_sqe_files_unregister(), here:
>>
>> /* wait for all refs nodes to complete */
>> wait_for_completion(&data->done);
>>
>> I'll try and debug this a bit, and for some reason it doens't trigger
>> with the liburing fixed file setup. Just wanted to throw this out there,
>> so if you have cycles, please do take a look at it.
>
> https://lore.kernel.org/io-uring/[email protected]/T/#u
Thanks for this fix, and sorry, it's my bad, I didn't cover this case when sending patches.
Can you share your test cases or test method when developing io_uring? Usually I just
run test cases under liburing/test, seems it's not enough.
Regards,
Xiaoguang Wang
>
>
next prev parent reply other threads:[~2020-05-14 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 18:45 regression: fixed file hang Jens Axboe
2020-05-13 19:04 ` Jens Axboe
2020-05-14 5:33 ` Xiaoguang Wang [this message]
2020-05-14 15:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2b8f17-dd3e-c31f-d8a0-737774a2bb92@linux.alibaba.com \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox