From: Jens Axboe <[email protected]>
To: Gabriel Krisman Bertazi <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH liburing] io_uring.h: Avoid anonymous enums
Date: Thu, 28 Mar 2024 07:45:17 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/27/24 6:16 PM, Gabriel Krisman Bertazi wrote:
> anonymous enums, while valid, confuses Cython (Python to C translator),
> as reported by Ritesh (YoSTEALTH) . Since people are using this, just
> name the existing enums.
>
> See https://github.com/cython/cython/issues/3240.
>
> Signed-off-by: Gabriel Krisman Bertazi <[email protected]>
>
> ---
> Do we want to sync with the kernel header?
Yeah, usually the kernel side gets updates, and then liburing syncs it.
That's how it needs to be done as the kernel side is driving
improvements or new features. So I think we'd want to do this on the
kernel side first, then sync it back to liburing afterwards as a follow
up patch.
--
Jens Axboe
prev parent reply other threads:[~2024-03-28 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 0:16 [PATCH liburing] io_uring.h: Avoid anonymous enums Gabriel Krisman Bertazi
2024-03-28 13:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox