public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Roesch <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: [email protected], [email protected], [email protected],
	[email protected], [email protected],
	[email protected], [email protected]
Subject: Re: [RFC PATCH v4 07/17] iomap: Use balance_dirty_pages_ratelimited_flags in iomap_write_iter
Date: Wed, 25 May 2022 14:32:17 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>



On 5/22/22 12:19 AM, Christoph Hellwig wrote:
> On Fri, May 20, 2022 at 11:36:36AM -0700, Stefan Roesch wrote:
>> @@ -765,14 +765,22 @@ static loff_t iomap_write_iter(struct iomap_iter *iter, struct iov_iter *i)
>>  	do {
>>  		struct folio *folio;
>>  		struct page *page;
>> +		struct address_space *mapping = iter->inode->i_mapping;
>>  		unsigned long offset;	/* Offset into pagecache page */
>>  		unsigned long bytes;	/* Bytes to write to page */
>>  		size_t copied;		/* Bytes copied from user */
>> +		unsigned int bdp_flags =
>> +			(iter->flags & IOMAP_NOWAIT) ? BDP_ASYNC : 0;
> 
> Bot the mapping and bdp_flags don't change over the loop iterations,
> so we can initialize them once at the start of the function.
> 

Moved the variable definitions outside of the loop.

> Otherwise this looks good, but I think this should go into the
> previous patch as it is a central part of supporting async buffered
> writes.
>

I merged it with the previous patch.
 

  reply	other threads:[~2022-05-25 21:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 18:36 [RFC PATCH v4 00/17] io-uring/xfs: support async buffered writes Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 01/17] mm: Move starting of background writeback into the main balancing loop Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 02/17] mm: Move updates of dirty_exceeded into one place Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 03/17] mm: Prepare balance_dirty_pages() for async buffered writes Stefan Roesch
2022-05-22  7:17   ` Christoph Hellwig
2022-05-25 21:30     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 04/17] mm: Add balance_dirty_pages_ratelimited_flags() function Stefan Roesch
2022-05-23 10:40   ` Jan Kara
2022-05-20 18:36 ` [RFC PATCH v4 05/17] iomap: Add gfp parameter to iomap_page_create() Stefan Roesch
2022-05-22  7:21   ` Christoph Hellwig
2022-05-25 21:29     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 06/17] iomap: Add async buffered write support Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 07/17] iomap: Use balance_dirty_pages_ratelimited_flags in iomap_write_iter Stefan Roesch
2022-05-22  7:19   ` Christoph Hellwig
2022-05-25 21:32     ` Stefan Roesch [this message]
2022-05-20 18:36 ` [RFC PATCH v4 08/17] fs: Add check for async buffered writes to generic_write_checks Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 09/17] fs: Split off remove_needs_file_privs() __remove_file_privs() Stefan Roesch
2022-05-22  7:32   ` Christoph Hellwig
2022-05-25 21:34     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 10/17] fs: Split off file_needs_update_time and __file_update_time Stefan Roesch
2022-05-22  7:29   ` Christoph Hellwig
2022-05-25 22:32     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 11/17] fs: Add async write file modification handling Stefan Roesch
2022-05-22  7:24   ` Christoph Hellwig
2022-05-25 21:39     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 12/17] fs: Optimization for concurrent file time updates Stefan Roesch
2022-05-23 10:51   ` Jan Kara
2022-05-25 21:46     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 13/17] io_uring: Add support for async buffered writes Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 14/17] io_uring: Add tracepoint for short writes Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 15/17] xfs: Add iomap async buffered write support Stefan Roesch
2022-05-22  7:33   ` Christoph Hellwig
2022-05-25 21:40     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 16/17] xfs: Add " Stefan Roesch
2022-05-22  7:34   ` Christoph Hellwig
2022-05-25 21:41     ` Stefan Roesch
2022-05-22 15:35   ` Darrick J. Wong
2022-05-25 21:44     ` Stefan Roesch
2022-05-20 18:36 ` [RFC PATCH v4 17/17] xfs: Enable " Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox