Re: [PATCH 2/2] tests: timestamp example

[Jens Axboe <axboe@kernel.dk>]

On 6/30/25 10:09 AM, Pavel Begunkov wrote:
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>

A bit of commit message might be nice? Ditto the other patch.
I know they are pretty straight forward, but doesn't hurt to
spell out a bit why the change is being made.

> +#ifndef SCM_TS_OPT_ID
> +#define SCM_TS_OPT_ID 0
> +#endif

This one had me a bit puzzled, particularly with:

> +	if (SCM_TS_OPT_ID == 0) {
> +		fprintf(stderr, "no SCM_TS_OPT_ID, skip\n");
> +		return T_EXIT_SKIP;
> +	}

as that'll just make the test skip on even my debian unstable/testing
base as it's still not defined there. But I guess it's because it's arch
specific? FWIW, looks like anything but sparc/parisc define it as 81,
hence in terms of coverage might be better to simply define it for
anything but those and actually have the test run?

-- 
Jens Axboe