From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7D6C0044D for ; Sun, 15 Mar 2020 01:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED83220637 for ; Sun, 15 Mar 2020 01:42:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="E/h3JWyS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726705AbgCOBmA (ORCPT ); Sat, 14 Mar 2020 21:42:00 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40303 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbgCOBmA (ORCPT ); Sat, 14 Mar 2020 21:42:00 -0400 Received: by mail-pf1-f195.google.com with SMTP id l184so7675511pfl.7 for ; Sat, 14 Mar 2020 18:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=+/247cTfFPmb6HzvLpP0YBhAOHansbCR7qRIbohrXkI=; b=E/h3JWySV60dxpGI2gxROTmY2mZeLVVOoioeXtEAq5DSRgyFBnAaTzBmVeIOUJNDYl pUNhavjej7XYrSfD7CWWOuCQN17b3T9dPhuBnfOH76BnRFd+wRSYWOVsmliAt0etk6gg DYJ9Nv8nF8GNuZpxgUZhrLeusJaLQzZk3lUmayLRYGH1E/E/grkRjfJTS3je8tzmbuNT Ys2H/0GpAbMCnru4/QcjKJ9ceya9viY3VelMvPMhmkU80VYVbvQPyyt1+sCejng8cLnA uCL0+aT+3hLuQZPQ2jhC27DjOTakBFMCjqAPDGe7DidgAz3Dl9rvTVjknDflOsLeEvbr IbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+/247cTfFPmb6HzvLpP0YBhAOHansbCR7qRIbohrXkI=; b=swcTS+7arDVcLGl3pej8m7Xjp8wUZmLWuq1uAsTrmVbl3oB/XSX4B52CaC6QOrrOP8 E+9g1udba0p8NI8hw4ZVdzFBqwgy2CVraXgzjH5EU+7RMJVYtOiGDK/eMq2GPuixau0c lYYHbaSTbQuQcKnQdglSdhTmJuNiJrhHISSMGN4l7aPIoZw703DAy09I0kwsSsEG4XNb XwWVU/4WMalPNAfI1Y5zI2I+9Q5bsg+2uR+UZFVbkJBOJdMDwmypOC0miYdcBAbD19je U2aRjxCznWgSJAcRHq9hpaZj+wAErD0mCHPCJgdvx/04qIyMQpqTyjqqNNoUwlF0BdFk jhJQ== X-Gm-Message-State: ANhLgQ1EihYOzvMKKTu/Tvs1AbuzbbhQkZIuccXWMa6GD2x9E5VK1IkM HOze7S+2QsujQGVMR3KSfSSJ/aUDk5EUUQ== X-Google-Smtp-Source: ADFU+vs4bDd5BE7tlACCr4VBGaQq1i1YtcLAWyKDg8BNV4CX7P6+yrkgL79vVx2ZqcEl5BQ5gzfj3w== X-Received: by 2002:a63:8b42:: with SMTP id j63mr19006128pge.27.1584226866175; Sat, 14 Mar 2020 16:01:06 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id g6sm12179905pjv.13.2020.03.14.16.01.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2020 16:01:05 -0700 (PDT) Subject: Re: [PATCH 5.6] io_uring: NULL-deref for IOSQE_{ASYNC,DRAIN} To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <3fff749b19ae1c3c2d59e88462a8a5bfc9e6689f.1584127615.git.asml.silence@gmail.com> <6ebc5e8a-7a6c-2537-9050-fe4e5c4f014d@gmail.com> From: Jens Axboe Message-ID: Date: Sat, 14 Mar 2020 17:01:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <6ebc5e8a-7a6c-2537-9050-fe4e5c4f014d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/13/20 3:29 PM, Pavel Begunkov wrote: > On 13/03/2020 23:28, Pavel Begunkov wrote: >> Hmm, found unreliably failing the across-fork test. I don't know whether it's >> this patch specific, but need to take a look there first. > > It's good to go, just used outdated tests. > The reproducer is attached. I integrated this into the existing read-write in liburing, thanks. -- Jens Axboe