From: Jens Axboe <[email protected]>
To: Kanchan Joshi <[email protected]>
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] io_uring: fix error handling for io_uring_cmd
Date: Thu, 11 Aug 2022 12:08:43 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20220811175709.GB16993@test-zns>
On 8/11/22 11:57 AM, Kanchan Joshi wrote:
>>> BTW, we noticed the original issue while testing fixedbufs support.
>>> Thinking to add a liburing test that involves sending a command which
>>> nvme will fail during submission. Can come in handy.
>>
>> I think that's a good idea - if you had eg a NOP linked after a passthru
>> command that failed, then that would catch this case.
>
> Right. For now in liburing test we don't do anything that is guranteed
> to fail from nvme-side. Test issues iopoll (that fails) but that failure
> comes from io_uring itself (as .iopoll is not set). So another test that
> will form a bad passthru command (e.g. wrong nsid) which only nvme can
> (and will) fail.
Yes, that's a good idea in general, testing only successful completions
doesn't really give full coverage.
--
Jens Axboe
prev parent reply other threads:[~2022-08-11 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220811092503epcas5p2e945f7baa5cb0cd7e3d326602c740edb@epcas5p2.samsung.com>
2022-08-11 9:14 ` [PATCH] io_uring: fix error handling for io_uring_cmd Anuj Gupta
2022-08-11 15:38 ` Jens Axboe
2022-08-11 16:55 ` Jens Axboe
2022-08-11 17:35 ` Kanchan Joshi
2022-08-11 17:51 ` Jens Axboe
2022-08-11 17:57 ` Kanchan Joshi
2022-08-11 18:08 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox