From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from xry111.site (xry111.site [89.208.246.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667FA182B2; Thu, 4 Jul 2024 03:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.208.246.23 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720063404; cv=none; b=InCgoW/WrqFGoXORoTJ7UmqmQRd7HHPhrAMZExs3rpBoABjuX5rDjhvKxLcVgAvH3nbMwrQhQnuHjjG/sKI6jsiLAMnl4HhvRJ20lqQtIkbZt92cQfq9kNdrgKilkB9fUStJF2tcF1pXwhZ0HShcEwkkd/CIq1DoalfloqQCnqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720063404; c=relaxed/simple; bh=53fepz8ZVbxIlcp3kjh7KlVSnkO3U05UcRI1647roAY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hOxD8Wb28mapHV5ovR7hGHnq2ECZFct2Vfh3n8tCNGRstpw3tUqjFRJdzJRfQNdUtDXOR5NyjbEu47cpQHGdngs/mLuynWoOSlgsK2GtQLf5zGBlJCBJ9SVUggKBmWT8QwTTts6dv+pO3/Whw1NlXIvMWz1DLfe3wcTLHBTLOGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xry111.site; spf=pass smtp.mailfrom=xry111.site; dkim=pass (1024-bit key) header.d=xry111.site header.i=@xry111.site header.b=D6HYxOgq; arc=none smtp.client-ip=89.208.246.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xry111.site Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xry111.site header.i=@xry111.site header.b="D6HYxOgq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1720063401; bh=53fepz8ZVbxIlcp3kjh7KlVSnkO3U05UcRI1647roAY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=D6HYxOgqaJ4vtiXeD9CCrm+zu9TkU7Zn6K36z8wAUnjX6uij8Q+H1/9VwOJc92e/c 76hDJVUBkSUOksnfzDq8xGZQ5IM/+rROLojhnv55PxH+8Wiq0PCun7GYnFQWu28855 GX7v9ueRKkzmJ7OBMFgK7bVjZOtA9nf5DDkqLCyY= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id E19FC6591E; Wed, 3 Jul 2024 23:23:18 -0400 (EDT) Message-ID: Subject: Re: [PATCH 2/2] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...) From: Xi Ruoyao To: Huacai Chen Cc: Linus Torvalds , Christian Brauner , libc-alpha@sourceware.org, "Andreas K. Huettel" , Arnd Bergmann , Mateusz Guzik , Alexander Viro , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Jens Axboe , loongarch@lists.linux.dev Date: Thu, 04 Jul 2024 11:23:17 +0800 In-Reply-To: References: <20240625110029.606032-1-mjguzik@gmail.com> <20240625110029.606032-3-mjguzik@gmail.com> <30907b42d5eee6d71f40b9fc3d32ae31406fe899.camel@xry111.site> <1b5d0840-766b-4c3b-8579-3c2c892c4d74@app.fastmail.com> <8f2d356d-9cd6-4b06-8e20-941e187cab43@app.fastmail.com> <20240703-bergwacht-sitzung-ef4f2e63cd70@brauner> <8b6d59ffc9baa57fee0f9fa97e72121fd88cf0e4.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-07-04 at 10:38 +0800, Huacai Chen wrote: > > So if a LoongArch Glibc is built with Linux kernel headers >=3D 6.11, > > it'll use fstatat **even configured --with-kernel=3D5.19** and fail to = run > > on Linux kernel <=3D 6.10.=C2=A0 This will immediately blow up building= Linux > > From Scratch on a host distro with an "old" kernel. > The patch which adds newstat back will CC the stable list and be > backported to old kernels. AFAIK in Glibc --enable-kernel=3Dx.y (not with, I was too sleepy yesterday) means it'll work with even x.y.0. And even if we "re- purpose" x.y to mean "the latest x.y patch release" people can still explicitly spell the patch level, like --enable-kernel=3D5.19.0. Thus we still need to handle this in Glibc. And the backport will raise another question: assume 6.6.40 gets the backport, what should we do with --enable-kernel=3D6.6.40? Maybe we should we assume newfstatat is available but then people will start to complain "hey 6.9.7 > 6.6.40 but my Glibc configured with --enable- kernel=3D6.6.40 does not work on 6.9.7"... To me the only rational way seems only assuming 6.11 or later has newfstatat on LoongArch. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University