From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [RFC] io_uring: submit even with overflow backlog
Date: Thu, 15 Apr 2021 15:00:37 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 15/04/2021 14:59, Jens Axboe wrote:
> On 4/15/21 6:40 AM, Pavel Begunkov wrote:
>> Not submitting when have requests in overflow backlog looks artificial,
>> and limits users for no clear purpose, especially since requests with
>> resources are now not locked into it but it consists for a small memory
>> area. Remove the restriction.
>>
>> Signed-off-by: Pavel Begunkov <[email protected]>
>> ---
>>
>> Mainly for discussion. It breaks several tests, and so in theory
>> userspace, but can't think this restriction not being just a
>> nuisance to the userspace. IMHO much more convenient to allow it,
>> userspace can take care of it itself if needed, but for those
>> who don't care and use rings in parallel (e.g. different threads
>> for submission and completion), it will be hell of a synchronisation.
>
> I think we can kill it, with the main change enabling that being the
> cgroup memory accounting. This was kind of a safe guard to avoid having
Yeah, and not keeping requests, its resources and linking requests.
> silly cases just go way overboard, but I do agree that this is really
> up to the application to manage. And it may have an easier time doing
> so without -EBUSY on overflow being set on submit.
Btw, apparently that's the main reason for getting -EBUSY in mshot test,
just another lackmustest that it's not convenient.
--
Pavel Begunkov
next prev parent reply other threads:[~2021-04-15 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 12:40 [RFC] io_uring: submit even with overflow backlog Pavel Begunkov
2021-04-15 13:59 ` Jens Axboe
2021-04-15 14:00 ` Pavel Begunkov [this message]
2021-04-16 23:28 ` [PATCH] io_uring: don't fail submit " Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox