public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: take page references for NOMMU pbuf_ring mmaps
Date: Tue, 21 Apr 2026 10:21:04 -0600	[thread overview]
Message-ID: <aed22e56-a39b-4c4b-a413-b5b1cd64deb4@kernel.dk> (raw)
In-Reply-To: <c5077dde-0dfe-48d0-9504-76c7ff30b0e8@kernel.dk>

On 4/21/26 10:05 AM, Jens Axboe wrote:
> On 4/21/26 10:01 AM, Greg Kroah-Hartman wrote:
>> On Tue, Apr 21, 2026 at 03:55:38PM +0200, Greg Kroah-Hartman wrote:
>>> On Tue, Apr 21, 2026 at 07:50:32AM -0600, Jens Axboe wrote:
>>>> On 4/21/26 7:46 AM, Greg Kroah-Hartman wrote:
>>>>> Note, I have no way of testing this, I'm only forwarding this on because
>>>>> I got the bug report and was able to generate something that "seems"
>>>>
>>>> AI bug report I presume? Because I can't imagine anyone ever attempted
>>>> to run this.
>>>
>>> Yes, I got a bunch of "non-mmu" bug reports, which is a bit odd but I
>>> guess you can do that with qemu these days?  I should dig into that,
>>> maybe that way I can test this and get a reproducer for you.  If not,
>>> let's just bin the thing.
>>>
>>>>> correct, but it might be a total load of crap here, my knowledge of the
>>>>> vm layer is very low so take this for where it is coming from (i.e. a
>>>>> non-deterministic pattern matching system.)
>>>>>
>>>>> I do have another patch that just disables io_uring for !MMU systems, if
>>>>> you want that instead?  Or is this feature something that !MMU devices
>>>>> actually care about?
>>>>
>>>> I mean, who really cares about !MMU in the first place, we should just
>>>> kill that off with a passion.
>>>>
>>>> Let me take a closer look at this and bounce it past some vm people, my
>>>> nommu knowledge is close to zero as it's never been relevant in my
>>>> professional life time. Which is saying something...
>>>
>>> Let me try to get a reproducer going first, let's not waste any more
>>> human time on this just yet, sorry for sending this out without that
>>> done first...
>>
>> Ok, attached is a poc.c and a script to run it.  If you run this on a
>> 7.0 kernel today, it "should" crash. and then if you apply the patch it
>> doesn't (or at least that's what happened in my testing.)
>>
>> Note, I have run this locally, and it seems to work, but be careful, I
>> can't guarantee anything, it does seem quite odd in that it "crashes"
>> the kernel with a sysrq call to show "proof".  Although that is a cool
>> trick, I need to remember that...
> 
> I'll try and run a nommu qemu and see what pops out on my end. What a
> waste of time for a nothing burger ;-)

What is fix-paddr.py? It's referenced in the build script.

-- 
Jens Axboe


  reply	other threads:[~2026-04-21 16:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 13:46 [PATCH] io_uring: take page references for NOMMU pbuf_ring mmaps Greg Kroah-Hartman
2026-04-21 13:50 ` Jens Axboe
2026-04-21 13:55   ` Greg Kroah-Hartman
2026-04-21 14:02     ` Jens Axboe
2026-04-21 16:01     ` Greg Kroah-Hartman
2026-04-21 16:05       ` Jens Axboe
2026-04-21 16:21         ` Jens Axboe [this message]
2026-04-21 16:24           ` Greg Kroah-Hartman
2026-04-21 16:41             ` Jens Axboe
2026-04-21 17:04               ` Jens Axboe
2026-04-21 17:38                 ` Jens Axboe
2026-04-21 17:39 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aed22e56-a39b-4c4b-a413-b5b1cd64deb4@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox