From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77F6C636D4 for ; Wed, 15 Feb 2023 21:38:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229546AbjBOViN (ORCPT ); Wed, 15 Feb 2023 16:38:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjBOViK (ORCPT ); Wed, 15 Feb 2023 16:38:10 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB9BE2B0BA for ; Wed, 15 Feb 2023 13:38:09 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id d16so7674413ioz.12 for ; Wed, 15 Feb 2023 13:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2FjYikXxTsiCqHjFRWAjZux1kBU863fSvE+aPekbauo=; b=GPWhsJvb/WW7pzjrCf75f0Xg2BFGoWV9C2TyCSpjyhFPLqZmLxT82s41O09n/4vDgs X+/1CWpVzO6idwxlMcpdTuH0ft/fEyvNYWuSUK4xz7WJqJDZD+Y172SsHkFUjpWxiWsp zRXE4boMyc9JR9EmhT324QmQEjXiLlOtPWDoAyS73EljI9aLSXDI0AwD0pDqXXftuopK M2Klud7Puba02SuvkOSUyxW+/dxFwLuEI/Yg3rXKMZtaU05cRt0pYEbicDL/hTlba7n6 OIEMFTOF06LMBdDgg8E3cXDy2aaoIDhKumwavfsx52UZ0mebEjPH+v9QPbIRDzBG4Kaz kJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2FjYikXxTsiCqHjFRWAjZux1kBU863fSvE+aPekbauo=; b=ZiIh9o/18NLjSqqyHsMrgyQEGWVweqil3KYEg1Bgb/000Pyhx3dY9GPwGOlNtASATS xsJkR7gDzkK5yWPN1S+phKGzZN7YQ4rMXk57a3t9GwR1+CGn1B090FOxzFJedgwBEJf4 zD9goPVcyxqTsRreKFQFlmXzAW8ThYPEEoQhQmo0Oa2h8qo7aRDUfyo2RjuNV++yhDp9 ir/FnL7UZj6AIlYlDpwsfnCvmCOrrW+ZgxK/6FIW7sXpSKVnHYh82UwsLP5/BuYjzpQs DZRlUqmhdkO3+w5+soZYtt7RyRcQCDlpb0usw5UDL/SvzGiQLyAeCz/eHSlmNZju4eSv dm+g== X-Gm-Message-State: AO0yUKU5enmGTmfrKU4FME+iVhDWiR2re7UjMoDUMoRwKlbAPs5JyF6O 1CtM5cp+CAUng7WTAXCivxDtH/G+Mrqfd+NP X-Google-Smtp-Source: AK7set+1bkB/PhttX6TYUt72HaI3+Bx+fvgB52rMdCzu7v7BPKka7b7Mo4j/PszByHO6//OFTTNiQw== X-Received: by 2002:a05:6602:4149:b0:707:d0c0:1bd6 with SMTP id bv9-20020a056602414900b00707d0c01bd6mr2359168iob.1.1676497088926; Wed, 15 Feb 2023 13:38:08 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id r23-20020a028817000000b003a7c47efde0sm6121552jai.11.2023.02.15.13.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 13:38:08 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 14:38:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: io_uring failure on parisc with VIPT caches Content-Language: en-US To: John David Anglin , Helge Deller , io-uring@vger.kernel.org, linux-parisc@vger.kernel.org, James Bottomley References: <006e8db4-336f-6717-ecb0-d01a0e9bc483@kernel.dk> <626cee6f-f542-b7eb-16ca-1cf4e3808ca6@bell.net> <5f02fa8b-7fd8-d98f-4876-f1a89024b888@kernel.dk> <2b89f252-c430-1c44-7b30-02d927d2c7cb@gmx.de> <0bfe6cdb-2749-c08d-a1b2-ef46fed1ded3@bell.net> <07810314-94f6-0e9a-984b-0a286cbb59d3@kernel.dk> <4f4f9048-b382-fa0e-8b51-5a0f0bb08402@kernel.dk> <99a41070-f334-f3cb-47cd-8855c938d71f@bell.net> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/15/23 2:06 PM, John David Anglin wrote: > On 2023-02-15 3:37 p.m., Jens Axboe wrote: >>> System crashes running test buf-ring.t. >> Huh, what's the crash? > Not much info.  System log indicates an HPMC occurred. Unfortunately, recovery code doesn't work. >> >>> Running test buf-ring.t bad run 0/0 = -233 >> THis one, and the similar -223 ones, you need to try and dig into that. >> It doesn't reproduce for me, and it very much seems like the test case >> having a different view of what -ENOBUFS looks like and hence it fails >> when the kernel passes down something that is -ENOBUFS internally, but >> doesn't match the app -ENOBUFS value. Are you running a 64-bit kernel? >> Would that cause any differences? > I'm running a 64-bit kernel (6.1.12). > > I believe 32 and 64-bit kernels have same error codes. > > I see three places in io_uring where -ENOBUFS is returned.  They have similar code: > > retry_multishot: >         if (io_do_buffer_select(req)) { >                 void __user *buf; >                 size_t len = sr->len; > >                 buf = io_buffer_select(req, &len, issue_flags); >                 if (!buf) >                         return -ENOBUFS; buf-ring is using a kernel mapped user ring, so may indeed be the same kind of coloring issue that we saw with the main rings. -- Jens Axboe