public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [RFC] io_uring: print COMM on ctx_exit hang
Date: Wed, 6 Oct 2021 10:00:57 -0600	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <77c68af25c707073c2708465ae576f1a231cf961.1633533200.git.asml.silence@gmail.com>

On 10/6/21 9:15 AM, Pavel Begunkov wrote:
> io_ring_exit_work() hangs are hard to debug partly because there is not
> much information of who created the ctx by the time it's exiting, and
> the function is running in a wq context, so the task name tells us
> nothing. Save creator's task comm and print it when it hangs.
> 
> Signed-off-by: Pavel Begunkov <[email protected]>
> ---
> 
> Just for discussion, I hope there are better ways of doing it.
> 
> It leaves out the second wait_for_completion() in io_ring_exit_work(),
> which is of interest, so would be great to cover the case as well.

I've done identical patches in the past myself, and I don't think
there's a better way to do this. The task may be long gone, so we have
to capture it upfront.

-- 
Jens Axboe


      reply	other threads:[~2021-10-06 16:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 15:15 [RFC] io_uring: print COMM on ctx_exit hang Pavel Begunkov
2021-10-06 16:00 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox