Re: [PATCH v2 5/5] io_uring/netcmd: add tx timestamping cmd support

[Pavel Begunkov <asml.silence@gmail.com>]

On 6/6/25 09:33, Jason Xing wrote:
...>>> Sorry that I don't know how iouring works at a high level, so my
>>> question could be naive and unrelated to what Willem said.
>>>
>>> Is it possible that applications set various tx sw timestamp flags
>>> (like SOF_TIMESTAMPING_TX_SCHED, SOF_TIMESTAMPING_TX_SOFTWARE)? If it
>>
>> io_uring takes timestamps from the error queue, just like the socket
>> api does it. There should be different skbs in the queue for different
>> SCM_TSTAMP_{SND,SCHED,ACK,*} timestamps, io_uring only passes the
>> type it got in an skb's serr->ee.ee_info to user without changes.
>> Hope it answers it
> 
> Sure, thanks, io_uring has no difference from other regular
> applications in this case. Then the question that Willem proposed
> remains because in other applications struct scm_timestamping_internal
> can be used to distinguish sw and hw timestamps (please see
> __sock_recv_timestamp() as an example).

Right, that's exactly where I copied it from ;) I can certainly add
a flag if there is a need to distinguish software vs hardware
timestamps.

-- 
Pavel Begunkov