public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: Dylan Yudaken <dyudaken@gmail.com>
Subject: Re: [PATCH 1/1] io_uring/zctx: separate notification user_data
Date: Mon, 9 Mar 2026 07:24:30 -0600	[thread overview]
Message-ID: <af558995-aaee-47cb-8099-759462222370@kernel.dk> (raw)
In-Reply-To: <218c175c-680c-4ee2-9e00-c81202e4841b@gmail.com>

On 3/9/26 7:21 AM, Pavel Begunkov wrote:
> On 2/17/26 15:15, Jens Axboe wrote:
>> On 2/17/26 8:03 AM, Pavel Begunkov wrote:
>>> On 2/17/26 13:12, Jens Axboe wrote:
>>>> On 2/17/26 4:15 AM, Pavel Begunkov wrote:
> ...
>>>> The patch should just be removing that addr3 -EINVAL case, and adding
>>>> the two lines that check IORING_SEND_ZC_NOTIF_USER_DATA, and if set, assign
>>>> notif->cqe.user_data from addr3.
>>>>
>>>> But I object to saying this is a "degraded" uapi, to me it's very much a
>>>> better one as it allows all values of user_data, rather than have some
>>>> magic 0 value that's not valid for no other reason than force policy.
>>>
>>> Well, we clearly disagree on that one.
>>
>> In the spirit of making progress and not wasting anymore time on this
>> fairly fruitless discussion, I'm fine with adding the else branch, and
>> hence v2 as-is.
> 
> Looks like it got lost / forgotten? I can't find it in for-next

Indeed, I think that was waiting for last weeks rebase. Did both
now, was OOO Wed and on a plane back now, just catching up.

-- 
Jens Axboe


  reply	other threads:[~2026-03-09 13:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 11:48 [PATCH 1/1] io_uring/zctx: separate notification user_data Pavel Begunkov
2026-02-16 15:10 ` Jens Axboe
2026-02-16 15:48   ` Pavel Begunkov
2026-02-16 15:52     ` Jens Axboe
2026-02-16 15:53       ` Pavel Begunkov
2026-02-16 15:55         ` Jens Axboe
2026-02-16 17:20           ` Pavel Begunkov
2026-02-16 17:27             ` Jens Axboe
2026-02-17 11:15               ` Pavel Begunkov
2026-02-17 13:12                 ` Jens Axboe
2026-02-17 15:03                   ` Pavel Begunkov
2026-02-17 15:15                     ` Jens Axboe
2026-03-09 13:21                       ` Pavel Begunkov
2026-03-09 13:24                         ` Jens Axboe [this message]
2026-03-09 13:24 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af558995-aaee-47cb-8099-759462222370@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=dyudaken@gmail.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox