From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 1/1] io_uring: fix rsrc tagging on registration failure
Date: Fri, 4 Apr 2025 09:40:02 -0600 [thread overview]
Message-ID: <b075d31c-e49f-4150-abfc-660766ccc250@kernel.dk> (raw)
In-Reply-To: <2b3d9c22-fcd6-4422-8834-73f87d4c3df2@gmail.com>
On 4/4/25 9:37 AM, Pavel Begunkov wrote:
> On 4/4/25 15:55, Jens Axboe wrote:
>> On 4/4/25 8:46 AM, Pavel Begunkov wrote:
>>> Buffer / file table registration is all or nothing, if fails all
>>> resources we might have partially registered are dropped and the table
>>> is killed. When that happens it doesn't suppose to post any rsrc tag
>>> CQEs, that would be a surprise to the user and it can't be handled.
>>
>> Needs a bit of editing, but I can do that.
>>
>>> Cc: stable@vger.kernel.org
>>
>> We should either put a backport target on this, or a Fixes tag.
>> I guess a 6.1+ would suffice?
>
> Fixes: 7029acd8a9503 ("io_uring/rsrc: get rid of per-ring io_rsrc_node list")
>
> Looks like this one. Recent enough, I thought I'd be worse.
Oh yeah, that's nice and simple then.
--
Jens Axboe
next prev parent reply other threads:[~2025-04-04 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 14:46 [PATCH 1/1] io_uring: fix rsrc tagging on registration failure Pavel Begunkov
2025-04-04 14:55 ` Jens Axboe
2025-04-04 15:37 ` Pavel Begunkov
2025-04-04 15:40 ` Jens Axboe [this message]
2025-04-04 15:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b075d31c-e49f-4150-abfc-660766ccc250@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox