From: Xiaoguang Wang <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH] io_uring: don't hold fixed_file_data's lock when registering files
Date: Thu, 3 Sep 2020 12:35:53 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
hi，
> On 9/2/20 5:32 AM, Xiaoguang Wang wrote:
>> While registering new files by IORING_REGISTER_FILES, there're not
>> valid fixed_file_ref_node at the moment, so it's unnecessary to hold
>> fixed_file_data's lock when registering files.
>
> Even if that were the case (I haven't looked too closely at it yet),
> it would a) need a big comment explaining why, and b) some justification
> on why this would be a change we'd want to make.
>
> On b, are you seeing any tangible differences with this?
No, just found this by reading source codes.
Regards,
Xiaoguang Wang
>
next prev parent reply other threads:[~2020-09-03 4:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 11:32 [PATCH] io_uring: don't hold fixed_file_data's lock when registering files Xiaoguang Wang
2020-09-02 14:13 ` Jens Axboe
2020-09-03 4:35 ` Xiaoguang Wang [this message]
2020-09-03 11:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16114c8-7369-d6db-ceb3-2fecf3f020df@linux.alibaba.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox