From: Pavel Begunkov <[email protected]>
To: Bernd Schubert <[email protected]>, Jens Axboe <[email protected]>,
Kanchan Joshi <[email protected]>
Cc: [email protected], [email protected],
Li Zetao <[email protected]>
Subject: Re: [PATCH v2] io_uring: Change res2 parameter type in io_uring_cmd_done
Date: Tue, 3 Dec 2024 12:05:23 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 12/3/24 10:31, Bernd Schubert wrote:
> Change the type of the res2 parameter in io_uring_cmd_done from ssize_t
> to u64. This aligns the parameter type with io_req_set_cqe32_extra,
> which expects u64 arguments.
> The change eliminates potential issues on 32-bit architectures where
> ssize_t might be 32-bit.
>
> Only user of passing res2 is drivers/nvme/host/ioctl.c and it actually
> passes u64.
LGTM. We can also convert all parameters to match the ABI, i.e.
io_uring_cqe::res is s32, "ssize_t ret" is just truncated.
--
Pavel Begunkov
next prev parent reply other threads:[~2024-12-03 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 10:31 [PATCH v2] io_uring: Change res2 parameter type in io_uring_cmd_done Bernd Schubert
2024-12-03 12:05 ` Pavel Begunkov [this message]
2024-12-03 13:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox