* generic/471 regression with async buffered writes?
@ 2022-08-18 16:37 Darrick J. Wong
2022-08-18 17:00 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2022-08-18 16:37 UTC (permalink / raw)
To: fstests
Cc: io-uring, kernel-team, linux-mm, linux-xfs, linux-fsdevel, david,
jack, hch, axboe, willy, Stefan Roesch
Hi everyone,
I noticed the following fstest failure on XFS on 6.0-rc1 that wasn't
there in 5.19:
--- generic/471.out
+++ generic/471.out.bad
@@ -2,12 +2,10 @@
pwrite: Resource temporarily unavailable
wrote 8388608/8388608 bytes at offset 0
XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-RWF_NOWAIT time is within limits.
+pwrite: Resource temporarily unavailable
+(standard_in) 1: syntax error
+RWF_NOWAIT took seconds
00000000: aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa ................
*
-00200000: bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................
-*
-00300000: aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa ................
-*
read 8388608/8388608 bytes at offset 0
XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
Is this related to the async buffered write changes, or should I keep
looking? AFAICT nobody else has mentioned problems with 471...
--D
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: generic/471 regression with async buffered writes?
2022-08-18 16:37 generic/471 regression with async buffered writes? Darrick J. Wong
@ 2022-08-18 17:00 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-08-18 17:00 UTC (permalink / raw)
To: Darrick J. Wong, fstests
Cc: io-uring, kernel-team, linux-mm, linux-xfs, linux-fsdevel, david,
jack, hch, willy, Stefan Roesch
On 8/18/22 10:37 AM, Darrick J. Wong wrote:
> Hi everyone,
>
> I noticed the following fstest failure on XFS on 6.0-rc1 that wasn't
> there in 5.19:
>
> --- generic/471.out
> +++ generic/471.out.bad
> @@ -2,12 +2,10 @@
> pwrite: Resource temporarily unavailable
> wrote 8388608/8388608 bytes at offset 0
> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -RWF_NOWAIT time is within limits.
> +pwrite: Resource temporarily unavailable
> +(standard_in) 1: syntax error
> +RWF_NOWAIT took seconds
> 00000000: aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa ................
> *
> -00200000: bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................
> -*
> -00300000: aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa aa ................
> -*
> read 8388608/8388608 bytes at offset 0
> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>
> Is this related to the async buffered write changes, or should I keep
> looking? AFAICT nobody else has mentioned problems with 471...
The test is just broken. It made some odd assumptions on what RWF_NOWAIT
means with buffered writes. There's been a discussion on it previously,
I'll see if I can find the links. IIRC, the tldr is that the test
doesn't really tie RWF_NOWAIT to whether we'll block or not.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-18 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-18 16:37 generic/471 regression with async buffered writes? Darrick J. Wong
2022-08-18 17:00 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox