From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH 1/2] io_uring: wait potential ->release() on resurrect
Date: Fri, 19 Feb 2021 20:53:33 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2/19/21 8:47 PM, Pavel Begunkov wrote:
> On 20/02/2021 03:40, Jens Axboe wrote:
>> On 2/19/21 6:39 PM, Pavel Begunkov wrote:
>>> There is a short window where percpu_refs are already turned zero, but
>>> we try to do resurrect(). Play nicer and wait for all users to leave RCU
>>> section.
>>
>> We need to do something better than synchronize_rcu() here, that can
>> take a long time on a loaded box. I'll try and think about this one.
>
> It only happens when it can't be drained and there are task_works or
> signals. I have another patch, doing it via tryget, but it's uglier and
> I'd rather prefer synchronize_rcu for stable.
Right, but the task_work coming in may not be unlikely. So it's not
strictly an error path.
--
Jens Axboe
next prev parent reply other threads:[~2021-02-20 3:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 1:39 [PATCH 0/2] random fixes Pavel Begunkov
2021-02-20 1:39 ` [PATCH 1/2] io_uring: wait potential ->release() on resurrect Pavel Begunkov
2021-02-20 3:40 ` Jens Axboe
2021-02-20 3:47 ` Pavel Begunkov
2021-02-20 3:53 ` Jens Axboe [this message]
2021-02-20 1:39 ` [PATCH 2/2] io_uring: fix leaving invalid req->flags Pavel Begunkov
2021-02-20 4:17 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-02-20 17:21 [PATCH 0/2] resurrect Pavel Begunkov
2021-02-20 17:21 ` [PATCH 1/2] io_uring: wait potential ->release() on resurrect Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox